Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exploratory View] Enable functional tests #115951

Closed
wants to merge 11 commits into from
Closed

[Exploratory View] Enable functional tests #115951

wants to merge 11 commits into from

Conversation

shahzad31
Copy link
Contributor

Summary

Fixes #106934

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31 shahzad31 marked this pull request as ready for review October 26, 2021 14:31
@shahzad31 shahzad31 requested a review from a team as a code owner October 26, 2021 14:31
@shahzad31 shahzad31 self-assigned this Oct 26, 2021
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

dominiqueclarke
dominiqueclarke reviewed Oct 27, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been run through flaky test runner? Changes to functional tests should be run through flaky test runner.

@justinkambic
Copy link
Contributor

Changes to functional tests should be run through flaky test runner.

👍 It's good form to link the results to the PR.

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31
Copy link
Contributor Author

Has this been run through flaky test runner? Changes to functional tests should be run through flaky test runner.

I wouldn't consider it as a rule , only if you are certains about flakiness not being resolved.

But happy to try new buildkite flaky test runner.

@shahzad31 shahzad31 removed the v7.16.0 label Dec 6, 2021
@elastic elastic deleted a comment from kibanamachine Jan 14, 2022
@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31 shahzad31 added v8.2.0 and removed v8.0.0 labels Feb 8, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 391.7KB 391.8KB +76.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 requested a review from a team as a code owner February 28, 2022 19:34
@afgomez
Copy link
Contributor

afgomez commented Mar 28, 2022

This PR has been stale for a while. @shahzad31 is it still relevant?

@shahzad31
Copy link
Contributor Author

This PR has been stale for a while. @shahzad31 is it still relevant?

I will close this, and reopen if needed.

Feel free to pick it up if you want though.

@shahzad31 shahzad31 closed this Mar 28, 2022
@shahzad31 shahzad31 deleted the enable-func-test branch March 28, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke left review comments

Assignees

@shahzad31 shahzad31

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.2.0
Projects
None yet
Milestone
No milestone
7 participants
@shahzad31 @elasticmachine @justinkambic @kibana-ci @afgomez @dominiqueclarke @kibanamachine