Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register "minimal" feature privileges regardless of the current license level #115992

Merged
merged 10 commits into from
Oct 26, 2021
Merged

Register "minimal" feature privileges regardless of the current license level #115992

merged 10 commits into from
Oct 26, 2021

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Oct 21, 2021 •
edited
Loading

Summary

In this PR, we will allow minimal_* to give privileges to the feature associated. Also resolves #111631

Checklist

@XavierM XavierM added release_note:enhancement Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0 enhancement New value added to drive a business result labels Oct 21, 2021
@legrego legrego changed the title [SECURITY] bring minimal-* privilege up Register "minimal" feature privileges regardless of the current license level Oct 21, 2021
@XavierM XavierM requested a review from legrego October 25, 2021 15:36
@XavierM XavierM marked this pull request as ready for review October 26, 2021 01:04
@XavierM XavierM requested a review from a team as a code owner October 26, 2021 01:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@jportner jportner mentioned this pull request Oct 26, 2021
Closed
@XavierM XavierM enabled auto-merge (squash) October 26, 2021 17:02
@XavierM XavierM merged commit e185afe into elastic:master Oct 26, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 507.8KB 507.7KB -157.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 28, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115992 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115992 or prevent reminders by adding the backport:skip label.

@jportner jportner added the backport:skip This commit does not require backporting label Oct 29, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115992 or prevent reminders by adding the backport:skip label.

@jportner jportner removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 1, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 2, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 115992 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 2, 2021
@XavierM XavierM added v8.1.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting enhancement New value added to drive a business result release_note:enhancement Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minimal_all privilege for a feature with no subfeatures doesn't give any privs
5 participants
@XavierM @elasticmachine @kibanamachine @legrego @jportner