-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Use original input when updating existing embeddable #116026
[Canvas] Use original input when updating existing embeddable #116026
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
c637735
to
780f71c
Compare
c9eb937
to
931e68a
Compare
removing core team since I don't see any changes related to our domains |
1834014
to
151ceac
Compare
931e68a
to
eecc31c
Compare
💛 Build succeeded, but was flaky
Test FailuresMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
* [Canvas] Generic embeddable function (#104499) * Created generic embeddable function Fixed telemetry Updates expression on input change Fixed ts errors Store embeddable input to expression Added lib functions Added comments Fixed type errors Fixed ts errors Clean up Removed extraneous import Added context type to embeddable function def Fix import Update encode/decode fns Moved embeddable data url lib file Added embeddable test Updated comment * Fix reference extract/inject in embeddable fn * Simplify embeddable toExpression * Moved labsService to flyout.tsx * Added comment * [Canvas] Adds Save and Return Workflow (#111411) * [Canvas] Adds editor menu to Canvas (#113194) * Merge existing embeddable input with incoming embeddable input (#116026) * [Canvas] Extract and inject references for by-value embeddables (#115124) * Extract/inject references for by-value embeddables in embeddable function Fixed server interpreter setup Register external functions in canvas_plugin_src plugin def * Fixed ref name in embeddable.inject * Fixed ts errors * Fix missing type error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
This fixes a bug where the time range set on an embeddable in Canvas would get reset after editing the embeddable in it's respective editor and returning to Canvas.
Now if there is an incoming embeddable with the same id as an existing element, this extracts the original embeddable input from the expression and uses it as the base input object for the incoming embeddable input.
To test:
The time range on the embeddable should still show
Last 2 weeks
instead of resetting toLast 15 minutes
.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers
Fixed server interpreter setup
Register external functions in canvas_plugin_src plugin def