-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Adds the 8.0.0-beta1 release notes #116483
Conversation
Pinging @elastic/kibana-docs (Team:Docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maps
release notes lgtm, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stack Management notes LGTM. Thanks @KOTungseth !
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review on behalf of Platform Security.
All of our breaking changes in 8.0 are listed here: #111160
(you can ignore the ones that are marked as "Future", we have deprecated those but they are not breaking in 8.0)
I see in these 8.0.0-beta1 release notes you noted:
- Remove legacy audit logging
- Prevent disabling the security plugin (in "Removes
xpack.security.enabled
setting") - Prevent disabling the spaces plugin (in "Removes
enabled
settings from plugins") - Prevent disabling the encryptedSavedObjects plugin (in "Removes
enabled
settings from plugins") - Include ML feature in base privileges
I see in the 8.0.0-alpha2 release notes you noted:
- Remove kibana_dashboard_only_user role in favor of Kibana feature privileges
I did not see any mention of:
- Change Cases sub-feature to be a top-level feature (though maybe this should be in the "Elastic Security Solution Release Notes" instead?)
Also, we had a release note for "Add defaults for xpack.security.session.{lifespan,idleTimeout}" in 8.0.0-alpha1, but that has now changed a bit. The new default for xpack.security.session.idleTimeout
is now 8h instead of 1h. Should we updated it in the 8.0.0-beta1 release notes?
docs/CHANGELOG.asciidoc
Outdated
[discrete] | ||
[[breaking-111681]] | ||
.Removes `xpack.security.enabled` setting | ||
[%collapsible] | ||
==== | ||
*Details* + | ||
The `xpack.security.enabled` setting has been removed. For more information, refer to {kibana-pull}111681[#111681]. | ||
|
||
*Impact* + | ||
Use {ref}/security-settings.html#general-security-settings[`xpack.security.enabled`] in elasticsearch.yml. | ||
==== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a blanket section above titled "Removes enabled
settings from plugins".
On one hand I understand this is a bit different than the other plugins that can be disabled.
However, I'm not really sure that we need this separate release note for the Security plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we only completed it in a separate PR because we had some complex test changes to make as a result.
I'd personally lean towards a single section since that's more concise and the release notes are already massive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Can you take a final look to make sure it still makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
…to docs/8.0.0-beta1-rn
This should be documented in the Elastic Security Solution Release Notes.
I can make this change in a separate PR. |
💚 Build Succeeded
History
To update your PR or re-run it, just comment with: cc @KOTungseth |
* [DOCS] Adds the 8.0.0-beta1 release notes * Update docs/CHANGELOG.asciidoc Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Update docs/CHANGELOG.asciidoc Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Vis editor changes * [DOCS] Adds known ML issue * [DOCS] Edits ML PRs * [DOCS] Removes known issue * Update docs/CHANGELOG.asciidoc Co-authored-by: Luke Elmers <lukeelmers@gmail.com> * Update docs/CHANGELOG.asciidoc Co-authored-by: Luke Elmers <lukeelmers@gmail.com> * Update docs/CHANGELOG.asciidoc Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> * Review comments Co-authored-by: Lisa Cawley <lcawley@elastic.co> Co-authored-by: Luke Elmers <lukeelmers@gmail.com> Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
* [DOCS] Adds the 8.0.0-beta1 release notes * Update docs/CHANGELOG.asciidoc Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Update docs/CHANGELOG.asciidoc Co-authored-by: Lisa Cawley <lcawley@elastic.co> * Vis editor changes * [DOCS] Adds known ML issue * [DOCS] Edits ML PRs * [DOCS] Removes known issue * Update docs/CHANGELOG.asciidoc Co-authored-by: Luke Elmers <lukeelmers@gmail.com> * Update docs/CHANGELOG.asciidoc Co-authored-by: Luke Elmers <lukeelmers@gmail.com> * Update docs/CHANGELOG.asciidoc Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> * Review comments Co-authored-by: Lisa Cawley <lcawley@elastic.co> Co-authored-by: Luke Elmers <lukeelmers@gmail.com> Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com> Co-authored-by: Lisa Cawley <lcawley@elastic.co> Co-authored-by: Luke Elmers <lukeelmers@gmail.com> Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Summary
Adds the release notes for the 8.0.0-beta1 release.