Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds the 8.0.0-beta1 release notes #116483

Merged
merged 12 commits into from
Nov 1, 2021

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented Oct 27, 2021

@KOTungseth KOTungseth added Team:Docs v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 27, 2021
@KOTungseth KOTungseth self-assigned this Oct 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maps release notes lgtm, thanks!

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack Management notes LGTM. Thanks @KOTungseth !

docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
KOTungseth and others added 2 commits October 27, 2021 20:38
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review on behalf of Platform Security.
All of our breaking changes in 8.0 are listed here: #111160
(you can ignore the ones that are marked as "Future", we have deprecated those but they are not breaking in 8.0)

I see in these 8.0.0-beta1 release notes you noted:

  • Remove legacy audit logging
  • Prevent disabling the security plugin (in "Removes xpack.security.enabled setting")
  • Prevent disabling the spaces plugin (in "Removes enabled settings from plugins")
  • Prevent disabling the encryptedSavedObjects plugin (in "Removes enabled settings from plugins")
  • Include ML feature in base privileges

I see in the 8.0.0-alpha2 release notes you noted:

  • Remove kibana_dashboard_only_user role in favor of Kibana feature privileges

I did not see any mention of:

  • Change Cases sub-feature to be a top-level feature (though maybe this should be in the "Elastic Security Solution Release Notes" instead?)

Also, we had a release note for "Add defaults for xpack.security.session.{lifespan,idleTimeout}" in 8.0.0-alpha1, but that has now changed a bit. The new default for xpack.security.session.idleTimeout is now 8h instead of 1h. Should we updated it in the 8.0.0-beta1 release notes?

docs/CHANGELOG.asciidoc Outdated Show resolved Hide resolved
Comment on lines 428 to 438
[discrete]
[[breaking-111681]]
.Removes `xpack.security.enabled` setting
[%collapsible]
====
*Details* +
The `xpack.security.enabled` setting has been removed. For more information, refer to {kibana-pull}111681[#111681].

*Impact* +
Use {ref}/security-settings.html#general-security-settings[`xpack.security.enabled`] in elasticsearch.yml.
====
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a blanket section above titled "Removes enabled settings from plugins".

On one hand I understand this is a bit different than the other plugins that can be disabled.
However, I'm not really sure that we need this separate release note for the Security plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jportner Removes xpack.security.enabled setting is documented in a separate section is because the work was completed in #111681, and Removes enabled settings from plugins was completed in #113495. I can combine them if needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we only completed it in a separate PR because we had some complex test changes to make as a result.

I'd personally lean towards a single section since that's more concise and the release notes are already massive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Can you take a final look to make sure it still makes sense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

lcawl and others added 7 commits November 1, 2021 09:50
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
@KOTungseth
Copy link
Contributor Author

KOTungseth commented Nov 1, 2021

@jportner

I did not see any mention of:

  • Change Cases sub-feature to be a top-level feature (though maybe this should be in the "Elastic Security Solution Release Notes" instead?)

This should be documented in the Elastic Security Solution Release Notes.

Also, we had a release note for "Add defaults for xpack.security.session.{lifespan,idleTimeout}" in 8.0.0-alpha1, but that has now changed a bit. The new default for xpack.security.session.idleTimeout is now 8h instead of 1h. Should we updated it in the 8.0.0-beta1 release notes?

I can make this change in a separate PR.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @KOTungseth

@KOTungseth KOTungseth merged commit 99e2e79 into elastic:main Nov 1, 2021
@KOTungseth KOTungseth deleted the docs/8.0.0-beta1-rn branch November 1, 2021 21:53
@KOTungseth KOTungseth removed the backport:skip This commit does not require backporting label Nov 1, 2021
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Nov 1, 2021
* [DOCS] Adds the 8.0.0-beta1 release notes

* Update docs/CHANGELOG.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update docs/CHANGELOG.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Vis editor changes

* [DOCS] Adds known ML issue

* [DOCS] Edits ML PRs

* [DOCS] Removes known issue

* Update docs/CHANGELOG.asciidoc

Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

* Update docs/CHANGELOG.asciidoc

Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

* Update docs/CHANGELOG.asciidoc

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Review comments

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
KOTungseth added a commit that referenced this pull request Nov 1, 2021
* [DOCS] Adds the 8.0.0-beta1 release notes

* Update docs/CHANGELOG.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Update docs/CHANGELOG.asciidoc

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

* Vis editor changes

* [DOCS] Adds known ML issue

* [DOCS] Edits ML PRs

* [DOCS] Removes known issue

* Update docs/CHANGELOG.asciidoc

Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

* Update docs/CHANGELOG.asciidoc

Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

* Update docs/CHANGELOG.asciidoc

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Review comments

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants