-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new page for the deprecation logs #118722
Merged
sebelga
merged 3 commits into
ua/deprecation_logs_improvements
from
ua/deprecation_logs_to_own_page
Nov 16, 2021
Merged
Add new page for the deprecation logs #118722
sebelga
merged 3 commits into
ua/deprecation_logs_improvements
from
ua/deprecation_logs_to_own_page
Nov 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sebelga
added
Feature:Upgrade Assistant
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
labels
Nov 16, 2021
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
sabarasaba
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM, left one question only about a duped i18n id 🚀
...upgrade_assistant/public/application/components/overview/fix_issues_step/fix_issues_step.tsx
Outdated
Show resolved
Hide resolved
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]
HistoryTo update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Upgrade Assistant
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a dedicated page for the ES deprecation logs. I have then added an additional message in step 3 of the UA overview to access the page.
As the Upgrade assistant is a visual UI tool I've decided to hide the access to the deprecation logs page if the user does not have privilege to view the indexed logs in Observability.
With the privilege to read the
.logs-deprecation.elasticsearch-default
indexWithout the privilege to read the
.logs-deprecation.elasticsearch-default
indexScreenshots
Users who access the URL directly without the index privilege