Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new page for the deprecation logs #118722

Merged

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Nov 16, 2021

I've created a dedicated page for the ES deprecation logs. I have then added an additional message in step 3 of the UA overview to access the page.

As the Upgrade assistant is a visual UI tool I've decided to hide the access to the deprecation logs page if the user does not have privilege to view the indexed logs in Observability.

With the privilege to read the .logs-deprecation.elasticsearch-default index

Screenshot 2021-11-16 at 16 09 54

Without the privilege to read the .logs-deprecation.elasticsearch-default index

Screenshot 2021-11-16 at 15 51 19

Screenshots

Screenshot 2021-11-16 at 15 52 11

Screenshot 2021-11-16 at 15 52 25

Users who access the URL directly without the index privilege

Screenshot 2021-11-16 at 15 55 51

@sebelga sebelga requested a review from sabarasaba November 16, 2021 16:02
@sebelga sebelga added Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Nov 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM, left one question only about a duped i18n id 🚀

@sebelga sebelga merged commit 384f5f2 into ua/deprecation_logs_improvements Nov 16, 2021
@sebelga sebelga deleted the ua/deprecation_logs_to_own_page branch November 16, 2021 17:22
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 16, 2021

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests / Cluster upgrade when cluster is in the process of a rolling upgrade renders rolling upgrade message
  • [job] [logs] OSS CI Group #6 / dashboard app new charts library dashboard state "after all" hook for "Tile map with no changes will update with visualization changes"
  • [job] [logs] OSS CI Group #6 / dashboard app new charts library dashboard state Tile map with no changes will update with visualization changes
  • [job] [logs] Default CI Group #10 / maps app Add layer panel "before all" hook for "should show unsaved layer in layer TOC"
  • [job] [logs] Default CI Group #9 / maps app maps loaded from sample data ecommerce "before all" hook for "should load layers"
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Privileges check doesn't show analyze and resolve logs if it doesn't have the right privileges
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Privileges check permissions warning callout is hidden if user has the right privileges
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step 1 - Toggle log writing and collecting handles network error when fetching logging state
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step 1 - Toggle log writing and collecting handles network error when updating logging state
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step 1 - Toggle log writing and collecting shows callout when only loggerDeprecation is enabled
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step 1 - Toggle log writing and collecting toggles deprecation logging
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step 2 - Analyze logs Has a link to see logs in discover app
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step 2 - Analyze logs Has a link to see logs in observability app
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step 3 - Resolve log issues Allows user to reset last stored date
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step 3 - Resolve log issues Handles errors and can retry
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step 3 - Resolve log issues No deprecation issues
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step 3 - Resolve log issues Poll for logs count renders step as incomplete when a success state is followed by an error state
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step 3 - Resolve log issues Shows a toast if deleting cache fails
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step 3 - Resolve log issues With deprecation warnings
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step 4 - API compatibility header It shows copy with compatibility api header advice
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step status It's complete when there are no deprecation logs since last checkpoint
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step status It's incomplete when log collection is disabled
  • [job] [logs] Jest Tests / Overview - Fix deprecation logs step Step status It's incomplete when there are deprecation logs since last checkpoint
  • [job] [logs] Jest Tests / ServiceList with ML data renders the health column

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [bacfa21]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants