[Upgrade Assistant] Fix cits, a11y and functional tests #118778
Conversation
x-pack/plugins/upgrade_assistant/__jest__/client_integration/app/cluster_upgrade.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Great job @sabarasaba ! Overall looks good to me. I left a few comments around naming and organising tests (I think we can move all CIT in the same file for the es deprecation logs).
I left a comment for a change I didn't understand where we can interchangeably use different request mock with the same result.
x-pack/plugins/upgrade_assistant/__jest__/client_integration/app/cluster_upgrade.test.tsx
Show resolved
Hide resolved
.../__jest__/client_integration/es_deprecation_logs/fix_deprecation_logs/fix_logs_step.test.tsx
Outdated
Show resolved
Hide resolved
| await PageObjects.upgradeAssistant.navigateToFixDeprecationLogs(); | ||
|
|
||
| // Only click deprecation logging toggle if its not already enabled | ||
| if (!(await testSubjects.isDisplayed('externalLinksTitle'))) { |
There was a problem hiding this comment.
externalLinksTitle does not seem to reference the actual DOM node. It seems to be the title of the page "Analyze deprecation logs". Can we update it?
There was a problem hiding this comment.
Ahhh re-reading this if block, i think it can be safely deleted since deprecation toggle is enabled by default now. This was used before when we had to keep it enabled for all tests.
| await PageObjects.upgradeAssistant.clickDeprecationLoggingToggle(); | ||
| } | ||
|
|
||
| await retry.waitFor('UA external links title to be present', async () => { |
There was a problem hiding this comment.
What does it mean "external links"? I might miss the context.
There was a problem hiding this comment.
External links is the name of the component that shows links to the discovery and observability apps. I think this check can be removed now (see above).
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
This PR fixes the tests (CITs, functional and a11y) for the changes that got introduced in #118659