Add workplace search links to doc link service #118814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x-pack/plugins/enterprise_search/public/applications/workplace_search/routes.ts
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
lcawl
added
release_note:skip
pgayvallet
approved these changes
Nov 19, 2021
scottybollinger
suggested changes
Nov 19, 2021
x-pack/plugins/enterprise_search/public/applications/shared/licensing/manage_license_button.tsx
Outdated
Show resolved
Hide resolved
...lugins/enterprise_search/public/applications/shared/licensing/manage_license_button.test.tsx
Outdated
Show resolved
Hide resolved
...se_search/public/applications/app_search/components/synonyms/components/empty_state.test.tsx
Outdated
Show resolved
Hide resolved
...e_search/public/applications/app_search/components/search_ui/components/empty_state.test.tsx
Outdated
Show resolved
Hide resolved
...rise_search/public/applications/app_search/components/schema/components/empty_state.test.tsx
Outdated
Show resolved
Hide resolved
...applications/app_search/components/curations/views/curations_settings/curations_settings.tsx
Outdated
Show resolved
Hide resolved
...cations/app_search/components/curations/views/curations_settings/curations_settings.test.tsx
Outdated
Show resolved
Hide resolved
...e_search/public/applications/app_search/components/curations/components/empty_state.test.tsx
Outdated
Show resolved
Hide resolved
...se_search/public/applications/app_search/components/api_logs/components/empty_state.test.tsx
Outdated
Show resolved
Hide resolved
I deleted that one since the only thing it was testing was the stem of the docs URLs and those no longer exist. I've re-added it with a smattering of URLs and the docLinksServiceMock: e3a0fe4 |
…h/components/api_logs/components/empty_state.test.tsx Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
…h/components/curations/components/empty_state.test.tsx Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
…h/components/curations/views/curations_settings/curations_settings.test.tsx Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
…h/components/curations/views/curations_settings/curations_settings.tsx Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
…h/components/engine_overview/engine_overview_empty.test.tsx Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
…h/components/documents/components/empty_state.test.tsx Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
|
@elasticmachine merge upstream |
scottybollinger
approved these changes
Nov 24, 2021
|
@lcawl looks like you have a merge conflict @byronhulcher @JasonStoltz can one of you review this? |
|
@elasticmachine update branch |
|
merge conflict between base and head |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Nov 29, 2021
Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
lcawl
added a commit
that referenced
this pull request
Nov 29, 2021
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #88107
This PR adds workplace search documentation URLs to the doc link service so that they can be tested and maintained. It removes the hard-coded links from to https://github.com/elastic/kibana/blob/main/x-pack/plugins/enterprise_search/public/applications/workplace_search/routes.ts and calls the doc link service from https://github.com/elastic/kibana/blob/main/x-pack/plugins/enterprise_search/public/applications/shared/doc_links/doc_links.ts instead.