Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] fix creating filter from array fields #119548

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Nov 23, 2021

Fixes #94736 and #87864

Create multiple match_phrase filter when value is an array. This mirrors the filtering experience of Discover.

@nreese nreese added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation backport:skip This commit does not require backporting v8.1.0 labels Nov 23, 2021
@nreese nreese requested a review from nickpeihl November 23, 2021 21:25
@nreese nreese requested a review from a team as a code owner November 23, 2021 21:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +33.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the fix!

code review and tested in chrome

@nreese nreese merged commit 7f2dbe5 into elastic:main Nov 24, 2021
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
* [Maps] fix creating filter from array fields

* eslint

* remove unneeded cast
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
* [Maps] fix creating filter from array fields

* eslint

* remove unneeded cast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating filter from array fields with multiple values creates invalid elasticsearch filter
4 participants