[Security Solution] host isolation exceptions add and edit exceptions by policy #119828

academo · 2021-11-29T12:16:07Z

xx## Summary

Implements adding and editing host isolation exceptions per-policy.

Add host isolation exception:

Edit host isolation exception:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This was checked for cross-browser compatibility

This reverts commit 2e1801c.

…ion-exceptions-add-edit-by-policy

elasticmachine · 2021-11-29T15:25:57Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

...anagement/components/artifact_entry_card/hooks/use_endpoint_policies_to_artifact_policies.ts

academo · 2021-11-29T18:03:40Z

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.ts

@@ -5,11 +5,20 @@
 * 2.0.
 */

+import type { DataViewBase, Query } from '@kbn/es-query';


Note: all changes are merely re-organize imports and change some paths.

…ion-exceptions-add-edit-by-policy

dasansol92

Left some comments. Also looking the screenshots I noticed the effect scope component doesn't fit the full flyout width, is this expected? It's weird to me having the description and the list of policies compressed
cc: @bfishel

x-pack/plugins/security_solution/public/management/components/effected_policy_select/utils.ts

...on/public/management/pages/host_isolation_exceptions/view/host_isolation_exceptions_list.tsx

…ion-exceptions-add-edit-by-policy

dasansol92 · 2021-12-01T08:57:24Z

@academo What about the effect scope "compressed width" issue? Is this expected? It seems it should fit the full flyout form width like in the Trusted Apps one

…ion-exceptions-add-edit-by-policy

academo · 2021-12-01T12:35:59Z

@academo What about the effect scope "compressed width" issue? Is this expected? It seems it should fit the full flyout form width like in the Trusted Apps one

It is fixed now.

...security_solution/public/management/pages/host_isolation_exceptions/view/components/form.tsx

x-pack/plugins/security_solution/public/management/components/effected_policy_select/utils.ts

…ion-exceptions-add-edit-by-policy

dasansol92

Thanks for the changes, lgtm! 🎉

joeypoon

🐑 🚀

…ion-exceptions-add-edit-by-policy

kibana-ci · 2021-12-04T19:31:25Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2797	2800	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	4.6MB	4.6MB	+2.2KB

History

💔 Build #11154 failed 3833571
💚 Build #10662 succeeded d1f505a
💚 Build #10319 succeeded 87aefd3
💛 Build #9959 was flaky 3aa2ef0
💚 Build #9737 succeeded 270f54c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

… by policy (elastic#119828)

Esteban Beltran added 21 commits November 17, 2021 10:41

Move effected policies component to common management components

904295c

Allow description prop and use fallback generic copy

df52a53

Style borders removing radius

67be8ed

Rename variable

3e4ac9f

Move policy ingest service to a common service

2e1801c

Revert "Move policy ingest service to a common service"

4e57894

This reverts commit 2e1801c.

Revert "Move policy ingest service to a common service"

e914304

This reverts commit 2e1801c.

Merge remote-tracking branch 'upstream/main' into feature/host-isolat…

a5da9b6

…ion-exceptions-add-edit-by-policy

Move query to custom hook

0dd114e

Merge remote-tracking branch 'upstream/main' into feature/host-isolat…

3f6ee48

…ion-exceptions-add-edit-by-policy

WIP: Add policies to host isolation exceptions

51e98f0

Apply policies and submit

7aa40e7

Fetch policies inside the form flyout

96922e0

Preserve previous policy selection

0582054

Show error for fetching policies

1d41e48

Improve form render performance

0f18595

Merge remote-tracking branch 'upstream/main' into feature/host-isolat…

9772deb

…ion-exceptions-add-edit-by-policy

Move policies specific hook to its own folder

1cc62cb

Fix existing form tests

de4db40

Update tests for host isolation exceptions form

9ee5593

Fix form tests

f399c1a

academo changed the title ~~[Security Solution[ host isolation exceptions add and edit exceptions by policy~~ [Security Solution] host isolation exceptions add and edit exceptions by policy Nov 29, 2021

Move policies service to its own folder

985a84f

academo marked this pull request as ready for review November 29, 2021 15:25

academo requested a review from a team as a code owner November 29, 2021 15:25

academo requested review from joeypoon and parkiino November 29, 2021 15:25

academo added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.1.0 labels Nov 29, 2021

academo requested a review from dasansol92 November 29, 2021 15:27

Display the name of policies on the artifact card

270f54c

academo commented Nov 29, 2021

View reviewed changes

...anagement/components/artifact_entry_card/hooks/use_endpoint_policies_to_artifact_policies.ts Show resolved Hide resolved

academo commented Nov 29, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/main' into feature/host-isolat…

e247c3c

…ion-exceptions-add-edit-by-policy

dasansol92 requested changes Nov 30, 2021

View reviewed changes

x-pack/plugins/security_solution/public/management/components/effected_policy_select/utils.ts Show resolved Hide resolved

...on/public/management/pages/host_isolation_exceptions/view/host_isolation_exceptions_list.tsx Outdated Show resolved Hide resolved

Esteban Beltran added 2 commits November 30, 2021 07:24

Merge remote-tracking branch 'upstream/main' into feature/host-isolat…

247948d

…ion-exceptions-add-edit-by-policy

Show error if policies can't be loaded

3aa2ef0

academo requested a review from dasansol92 November 30, 2021 13:48

Esteban Beltran added 2 commits December 1, 2021 07:19

Merge remote-tracking branch 'upstream/main' into feature/host-isolat…

e89b030

…ion-exceptions-add-edit-by-policy

Use full width for effected policies selector

87aefd3

dasansol92 reviewed Dec 2, 2021

View reviewed changes

Esteban Beltran added 3 commits December 2, 2021 07:04

Merge remote-tracking branch 'upstream/main' into feature/host-isolat…

42eed2f

…ion-exceptions-add-edit-by-policy

Add documentation

2d63d79

Preserve previous tags

a24a200

academo requested a review from dasansol92 December 2, 2021 13:04

Remove duplicated logic for isGlobal

d1f505a

dasansol92 approved these changes Dec 2, 2021

View reviewed changes

joeypoon approved these changes Dec 3, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/main' into feature/host-isolat…

3833571

…ion-exceptions-add-edit-by-policy

academo enabled auto-merge (squash) December 4, 2021 15:12

Remove unused dependency

8a65219

academo merged commit e527c3f into elastic:main Dec 4, 2021

kibanamachine added the backport:skip This commit does not require backporting label Dec 4, 2021

academo mentioned this pull request Dec 6, 2021

[Security Solution] Host isolation exceptions by policy, add missing validation when no policy is selected #120500

Merged

1 task

TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021

[Security Solution] host isolation exceptions add and edit exceptions…

b48c643

… by policy (elastic#119828)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] host isolation exceptions add and edit exceptions by policy #119828

[Security Solution] host isolation exceptions add and edit exceptions by policy #119828

academo commented Nov 29, 2021 •

edited

Loading

elasticmachine commented Nov 29, 2021

academo Nov 29, 2021

dasansol92 left a comment

dasansol92 commented Dec 1, 2021

academo commented Dec 1, 2021

dasansol92 left a comment

joeypoon left a comment

kibana-ci commented Dec 4, 2021

[Security Solution] host isolation exceptions add and edit exceptions by policy #119828

[Security Solution] host isolation exceptions add and edit exceptions by policy #119828

Conversation

academo commented Nov 29, 2021 • edited Loading

Checklist

elasticmachine commented Nov 29, 2021

academo Nov 29, 2021

Choose a reason for hiding this comment

dasansol92 left a comment

Choose a reason for hiding this comment

dasansol92 commented Dec 1, 2021

academo commented Dec 1, 2021

dasansol92 left a comment

Choose a reason for hiding this comment

joeypoon left a comment

Choose a reason for hiding this comment

kibana-ci commented Dec 4, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

academo commented Nov 29, 2021 •

edited

Loading