Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove star export in bfetch plugin #121806

Merged
merged 2 commits into from
Dec 28, 2021
Merged

remove star export in bfetch plugin #121806

merged 2 commits into from
Dec 28, 2021

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Dec 21, 2021 •
edited
Loading

Summary

Closes #109905

@vadimkibana vadimkibana mentioned this pull request Dec 21, 2021
Closed
20 tasks
@vadimkibana vadimkibana marked this pull request as ready for review December 22, 2021 16:29
@vadimkibana vadimkibana requested a review from a team as a code owner December 22, 2021 16:29
@vadimkibana vadimkibana requested a review from ppisljar December 22, 2021 16:29
@vadimkibana vadimkibana added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 Team:AppServicesSv labels Dec 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

ppisljar
ppisljar approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Dec 23, 2021
@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
bfetch 25 22 -3
Unknown metric groups

ESLint disabled in files

id before after diff
bfetch 2 1 -1

Total ESLint disabled count

id before after diff
bfetch 7 6 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana added the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 28, 2021
@vadimkibana vadimkibana merged commit 0cf392e into elastic:main Dec 28, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 28, 2021
@vadimkibana vadimkibana deleted the bfetch-star-export branch December 28, 2021 18:16
@kibanamachine
Copy link
Contributor

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 121806

@vadimkibana vadimkibana removed the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bfetch] remove reliance on eslint-rule-no-export-all
5 participants
@vadimkibana @elasticmachine @kibana-ci @kibanamachine @ppisljar