[UI Framework] Define consistent default, small, and wide sizing for form fields, and support them within ExpressionItems. #12190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
Team:Platform-Design
snide
reviewed
Jun 7, 2017
| @@ -80,3 +80,6 @@ $toolBarItsemSpacing: 10px; | |||
| $globalFormControlHorizontalPadding: 12px; | |||
| $globalFormControlPadding: 3px $globalFormControlHorizontalPadding 4px; | |||
| $globalFormInputHeight: 30px; | |||
| $globalFormFieldDefaultWidth: 180px; | |||
| $globalFormFieldSmallWidth: 60px; | |||
| $globalFormFieldLargeWidth: 400px; | |||
There was a problem hiding this comment.
Might want to follow a pattern with your sizes.
$globalFormFieldSmallWidth: $globalFormFieldDefaultWidth / 3;
$globalFormFieldLargeWidth: $globalFormFieldDefaultWidth * 2;
...etc. Just some sort of math so that when they sit next to each other they look like they were planned.
There was a problem hiding this comment.
I like the idea of applying some rhythms that make sense, but as it is they're just chosen because they look good in different scenarios. Can we get together at some point and figure out a rhythm that we can apply here so the values aren't so arbitrary?
|
That bug you found with the Watcher table is actually a problem with their markup. I'll address that in another issue. |
|
@snide I looked through through the UI and didn't find anything weird. Can you take another look and approve the PR? |
…d support them within ExpressionItems.
cjcenizal
force-pushed
the
improvement/expression-editor-input
branch
from
35b0236 to
737e456
Compare
snide
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BigFunger This should fix the problem you've been having with putting different sizes of inputs into an expression.