Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use doc link service in ILM #122104

Merged
merged 8 commits into from
Jan 10, 2022
Merged

Use doc link service in ILM #122104

merged 8 commits into from
Jan 10, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 29, 2021

Summary

Relates to #88107

This PR substitutes the documentation link service for hard-coded links in the ILM app.

@lcawl lcawl added Feature:ILM release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Dec 29, 2021
@lcawl lcawl mentioned this pull request Dec 29, 2021
Closed
@lcawl
Copy link
Contributor Author

lcawl commented Dec 31, 2021

@elasticmachine merge upstream

@lcawl
Copy link
Contributor Author

lcawl commented Jan 6, 2022

@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review January 6, 2022 20:47
@lcawl lcawl requested a review from a team as a code owner January 6, 2022 20:47
@cjcenizal cjcenizal added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Jan 7, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

sabarasaba
sabarasaba approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @lcawl! I had a look at the code and changes lgtm, left one small nit about some types 🚀

...licy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx Outdated Show resolved Hide resolved
@lcawl
Copy link
Contributor Author

lcawl commented Jan 10, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexLifecycleManagement 183 182 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 148.0KB 148.4KB +349.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexLifecycleManagement 28.0KB 27.7KB -349.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit b5d5ba9 into elastic:main Jan 10, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 10, 2022
@lcawl lcawl deleted the ilm-links2 branch January 10, 2022 22:24
@lcawl lcawl added v8.0.0 and removed backport:skip This commit does not require backporting labels Jan 10, 2022
lcawl added a commit to lcawl/kibana that referenced this pull request Jan 10, 2022
@lcawl
Use doc link service in ILM (elastic#122104)
24b9d1a 
(cherry picked from commit b5d5ba9)
@lcawl lcawl mentioned this pull request Jan 10, 2022
Merged
@lcawl
Copy link
Contributor Author

lcawl commented Jan 10, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Jan 11, 2022
@lcawl
[8.0] Use doc link service in ILM (#122104) (#122617)
2503fa6 
* Use doc link service in ILM (#122104)

(cherry picked from commit b5d5ba9)

* Fixes linting
@alstolten alstolten mentioned this pull request May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

Assignees
No one assigned
Labels
Feature:ILM release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcawl @elasticmachine @kibana-ci @sabarasaba @cjcenizal @kibanamachine