-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create server-side docLinks service #123818
Create server-side docLinks service #123818
Conversation
Pinging @elastic/kibana-core (Team:Core) |
links: docLinks, | ||
}; | ||
return this.docLinks; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the client, we're only exposing the docLinks from the start contract, however on the server-side, I think there's some scenarios where consumers will need to access it at setup too, so I exposed it from both lifecycles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me! Thanks for doing this @pgayvallet!
I just added a few nits for your consideration.
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Summary
Fix #95389
✔️ Depends on elastic/docs#2360
@kbn/doc-links
packagesrc/core/public/doc_links
to itDocLinks
serviceNote: due to the amount of docLinks changes, I will resolve all the conflict at the same time before merging once the PR gets approved
Checklist