Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade Assistant] Minimize reindex attributes used to create credential hash #123864

Merged
merged 1 commit into from
Jan 27, 2022
Merged

[Upgrade Assistant] Minimize reindex attributes used to create credential hash #123864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions x-pack/plugins/upgrade_assistant/server/lib/reindexing/credential_store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,14 @@ import { ReindexSavedObject, ReindexStatus } from '../../../common/types';
export type Credential = Record<string, any>;

// Generates a stable hash for the reindex operation's current state.
const getHash = (reindexOp: ReindexSavedObject) =>
createHash('sha256')
.update(stringify({ id: reindexOp.id, ...reindexOp.attributes }))
const getHash = (reindexOp: ReindexSavedObject) => {
// Remove reindexOptions from the SO attributes as it creates an unstable hash
// This needs further investigation, see: https://github.com/elastic/kibana/issues/123752
const { reindexOptions, ...attributes } = reindexOp.attributes;
return createHash('sha256')
.update(stringify({ id: reindexOp.id, ...attributes }))
.digest('base64');
};

// Returns a base64-encoded API key string or undefined
const getApiKey = async ({
Expand Down