Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip for Surrounding documents #123890

Merged
merged 7 commits into from
Feb 16, 2022
Merged

Add tooltip for Surrounding documents #123890

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
78e7f86
Add tooltip for Surrounding documents
lcawl Jan 27, 2022
317870f
Switch to icontip
lcawl Jan 27, 2022
2c71219
Merge branch 'main' into discover-help
kibanamachine Feb 14, 2022
9b48ca0
Update src/plugins/discover/public/components/discover_grid/discover_…
lcawl Feb 14, 2022
324a2a8
Removes unnecessary size property
lcawl Feb 14, 2022
72165b8
Change size properties for single document
lcawl Feb 14, 2022
9c16b12
Merge branch 'main' into discover-help
kibanamachine Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 37 additions & 13 deletions src/plugins/discover/public/components/discover_grid/discover_grid_flyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
EuiFlyout,
EuiFlyoutBody,
EuiFlyoutHeader,
EuiIconTip,
EuiTitle,
EuiButtonEmpty,
EuiText,
Expand Down Expand Up @@ -160,19 +161,42 @@ export function DiscoverGridFlyout({
</EuiButtonEmpty>
</EuiFlexItem>
{indexPattern.isTimeBased() && indexPattern.id && (
<EuiFlexItem grow={false}>
<EuiButtonEmpty
size="xs"
iconType="documents"
flush="left"
{...surrDocsProps}
data-test-subj="docTableRowAction"
>
{i18n.translate('discover.grid.tableRow.viewSurroundingDocumentsLinkTextSimple', {
defaultMessage: 'Surrounding documents',
})}
</EuiButtonEmpty>
</EuiFlexItem>
<EuiFlexGroup alignItems="center" responsive={false} gutterSize="none">
<EuiFlexItem grow={false}>
<EuiButtonEmpty
size="xs"
lcawl marked this conversation as resolved.
Show resolved Hide resolved
iconType="documents"
flush="left"
{...surrDocsProps}
data-test-subj="docTableRowAction"
>
{i18n.translate(
'discover.grid.tableRow.viewSurroundingDocumentsLinkTextSimple',
{
defaultMessage: 'Surrounding documents',
}
)}
</EuiButtonEmpty>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiIconTip
content={i18n.translate(
'discover.grid.tableRow.viewSurroundingDocumentsHover',
{
defaultMessage:
'Inspect documents that occurred before and after this document. Only pinned filters remain active in the Surrounding documents view.',
}
)}
type="questionInCircle"
color="subdued"
size="s"
lcawl marked this conversation as resolved.
Show resolved Hide resolved
position="right"
iconProps={{
className: 'eui-alignTop',
}}
/>
</EuiFlexItem>
</EuiFlexGroup>
)}
{activePage !== -1 && (
<EuiFlexItem data-test-subj={`dscDocNavigationPage-${activePage}`}>
Expand Down