You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
Risk
Probability
Severity
Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.
Low
High
Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.
High
Low
Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.
Medium
High
Unit tests will verify that any feature flag or plugin combination still results in our service operational.
[job][logs] Jest Tests #6 / date_histogram param editor should render current value
[job][logs] Jest Tests #6 / date_histogram param editor should render current value for other index pattern
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel should hide fields that have no data
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel should hide the top level field selector when switching from non-reference to reference
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel should keep the latest valid dimension when removing the selection in field combobox
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel should list all field names and document as a whole in prioritized order
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel should not display hidden operation types
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel should not set the state if selecting the currently active operation
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel should not update when selecting the current field again
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel should show all operations that are not filtered out
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel should show field select
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel should switch operations when selecting a field that requires another operation
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel should update label and custom label flag on label input changes
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel transient invalid state should indicate fields compatible with selected operation
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel transient invalid state should leave error state if a compatible operation is selected
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel transient invalid state should leave error state if the original operation is re-selected
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel transient invalid state should leave error state when switching from incomplete state to fieldless operation
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel transient invalid state should set datasource state if compatible field is selected for operation
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel transient invalid state should set the state if selecting an operation incompatible with the current field
[job][logs] Jest Tests #6 / IndexPatternDimensionEditorPanel transient invalid state should show error message in invalid state
[job][logs] Default CI Group #2 / Reporting APIs Report generation event logging creates a completed action for a PDF report
@flash1293@alexwizp I have a few questions for you two (and/or anyone else).
What is the current function of "auto" as an interval value? I can see that it is currently set as the default, but I think need an explicit value to position the range slider.
How should UI Settings play into this? I see that the slider in TSVB uses histogram:maxBars and histogram:barTarget, but I'm not sure if we should be using these in Lens also. histogram:barTarget appears to be what TSVB uses as its "auto" (default) setting.
What is a good way to create a restricted interval? I need to make my code work with restricted intervals but not sure how to create this scenario.
Should the slider somehow change the unit as well as the value?
Maybe instead of storing an explicit interval we can store the position of the slider (from 0 to 10) with 5 being auto, then dynamically turning it into an interval diverging from the auto value on building the expression? This way the slider is independently of the actual interval controlling the granularity (like the same slider for number histograms works).
What is a good way to create a restricted interval? I need to make my code work with restricted intervals but not sure how to create this scenario.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an interval granularity slider for data histogram operations.
Resolves #86437
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers