Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split date_nested kbn_archive out of es_archive #124646

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

LeeDr
Copy link

@LeeDr LeeDr commented Feb 4, 2022

Summary

The date_nested es_archive actually had 1 doc for the date_nested index and one index-pattern for the .kibana index. This breaks our ability to load the date_nested doc to a remote CCS index and the index-pattern to the local .kibana index. This PRs splits them into the es_archive and kbn_archive.

It was missed in #102552 but I'll add the reference to this archive.

@LeeDr LeeDr added release_note:skip Skip the PR/issue when compiling release notes v7.17.1 v8.0.1 v8.1.0 v8.2.0 auto-backport Deprecated - use backport:version if exact versions are needed Feature:Functional Testing test_ui_functional Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Feb 4, 2022
@LeeDr LeeDr marked this pull request as ready for review February 7, 2022 15:21
@LeeDr LeeDr requested a review from a team as a code owner February 7, 2022 15:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@LeeDr
Copy link
Author

LeeDr commented Feb 7, 2022

@elasticmachine merge upstream

@LeeDr LeeDr changed the title split kbn_archive out of es_archive split date_nested kbn_archive out of es_archive Feb 7, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] OSS CI Group #6 / discover app saved queries saved objects saved query management component functionality "before all" hook for "should show the saved query management component when there are no saved queries"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@cuff-links cuff-links left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ran locally. Works fine.

Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, given the tests pass, I believe it should be ok :)

@LeeDr LeeDr merged commit b8abe76 into elastic:main Feb 8, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 8, 2022
* split kbn_archive out of es_archive

* add missing unload of kbn_archive

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b8abe76)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 8, 2022
* split kbn_archive out of es_archive

* add missing unload of kbn_archive

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b8abe76)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 8, 2022
* split kbn_archive out of es_archive

* add missing unload of kbn_archive

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b8abe76)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1
8.0
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@LeeDr LeeDr deleted the splitArchivesDate_nested branch February 8, 2022 14:50
kibanamachine added a commit that referenced this pull request Feb 8, 2022
)

* split date_nested kbn_archive out of es_archive (#124646)

* split kbn_archive out of es_archive

* add missing unload of kbn_archive

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b8abe76)

* changing coreMigrationVersion to 8.0.0

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 8, 2022
)

* split date_nested kbn_archive out of es_archive (#124646)

* split kbn_archive out of es_archive

* add missing unload of kbn_archive

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b8abe76)

* change coreMigrationVersion to 8.0.0

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 9, 2022
…4965)

* split date_nested kbn_archive out of es_archive (#124646)

* split kbn_archive out of es_archive

* add missing unload of kbn_archive

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b8abe76)

* change coreMigrationVersion to 7.17.0

* Changing coreMigrationVersion to 7.11.0

I hope there wasn't any migrations since then

* changing another version to 7.11.0

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. test_ui_functional v7.17.1 v8.0.1 v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants