-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split date_nested kbn_archive out of es_archive #124646
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@elasticmachine merge upstream |
💛 Build succeeded, but was flakyTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ran locally. Works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks ok, given the tests pass, I believe it should be ok :)
* split kbn_archive out of es_archive * add missing unload of kbn_archive Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b8abe76)
* split kbn_archive out of es_archive * add missing unload of kbn_archive Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b8abe76)
* split kbn_archive out of es_archive * add missing unload of kbn_archive Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b8abe76)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
) * split date_nested kbn_archive out of es_archive (#124646) * split kbn_archive out of es_archive * add missing unload of kbn_archive Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b8abe76) * changing coreMigrationVersion to 8.0.0 Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
) * split date_nested kbn_archive out of es_archive (#124646) * split kbn_archive out of es_archive * add missing unload of kbn_archive Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b8abe76) * change coreMigrationVersion to 8.0.0 Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
…4965) * split date_nested kbn_archive out of es_archive (#124646) * split kbn_archive out of es_archive * add missing unload of kbn_archive Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b8abe76) * change coreMigrationVersion to 7.17.0 * Changing coreMigrationVersion to 7.11.0 I hope there wasn't any migrations since then * changing another version to 7.11.0 Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
Summary
The date_nested es_archive actually had 1 doc for the date_nested index and one index-pattern for the .kibana index. This breaks our ability to load the date_nested doc to a remote CCS index and the index-pattern to the local .kibana index. This PRs splits them into the es_archive and kbn_archive.
It was missed in #102552 but I'll add the reference to this archive.