Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker image for package-storage in tests #124799

Closed

Conversation

joshdover
Copy link
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@joshdover
Copy link
Contributor Author

@brianseeders Any recommendation on where we could put this value so that it could be shared across all of these locations rather than having to update it multiple places? Is a const in @kbn/test the best option?

@kibana-ci
Copy link
Collaborator

kibana-ci commented Feb 7, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Docker CI Group / Fleet Endpoints Package Policy - create should not allow multiple limited packages on the same agent policy
  • [job] [logs] Docker CI Group / Fleet Endpoints Package Policy - create should not allow multiple limited packages on the same agent policy

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders
Copy link
Contributor

@brianseeders Any recommendation on where we could put this value so that it could be shared across all of these locations rather than having to update it multiple places? Is a const in @kbn/test the best option?

I'm not really seeing any obvious places for it, so that's probably a good spot. You could also allow it to be overridden by an env var if that's useful? I don't know if people need to ever run it with a different image locally

@joshdover
Copy link
Contributor Author

handled in #125127

@joshdover joshdover closed this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants