[Fleet] Use registry version check on main #125495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
juliaElastic
approved these changes
Feb 14, 2022
kpollich
approved these changes
Feb 14, 2022
joshdover
added
the
auto-backport
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 14, 2022
(cherry picked from commit 9278294)
💔 Some backports could not be created
How to fixRe-run the backport manually: Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 14, 2022
joshdover
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 16, 2022
|
Handling 8.0 backport in #125672 |
kibanamachine
added a commit
that referenced
this pull request
Feb 16, 2022
…ilable in registry (#125525) (#125672) * [Fleet] Avoid breaking setup when compatible package is not available in registry (#125525) (cherry picked from commit 928638e) * [Fleet] Use registry version check on main (#125495) * [Fleet] Get package info should not store the whole package (#123509) Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #125409
We currently have special logic in place that removes the
kibana.versionparameter from requests to EPR when running on themainbranch. This makes testing logic around compatibility inflexible and leads to developers running different logic than we use in production.This removes this logic in preference of the
xpack.fleet.developer.disableRegistryVersionCheckconfig that was added previously. I did consider making this default totruein when running Kibana in development, but decided against it in order to facilitate using the production behavior by default and making the other logic more explicit.This does not affect production behavior at all.