Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kibana_react] Enable Storybook for all of kibana_react #125589

Merged
merged 2 commits into from
Feb 15, 2022
Merged

[kibana_react] Enable Storybook for all of kibana_react #125589

merged 2 commits into from
Feb 15, 2022

Conversation

clintandrewhall
Copy link
Contributor

Summary

As titled, and mentioned here, we should enable Storybook for all of kibana_react.

Testing

Run yarn storybook kibana_react.

@clintandrewhall clintandrewhall added review loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Feature:kibana-react v8.2.0 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Feb 14, 2022
@clintandrewhall clintandrewhall requested review from a team as code owners February 14, 2022 21:30
rshen91
rshen91 approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@rshen91 rshen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Tested locally and looked good thanks for implementing this

ThomThomson
ThomThomson approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team changes LGTM! Code only review

@clintandrewhall
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
kibanaReact 15 13 -2

Total ESLint disabled count

id before after diff
kibanaReact 21 19 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit 21cef49 into elastic:main Feb 15, 2022
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 17, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125589 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This commit does not require backporting label Feb 17, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimkibana vadimkibana vadimkibana approved these changes

@rshen91 rshen91 rshen91 approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@jbudz jbudz jbudz approved these changes

@majagrubic majagrubic majagrubic approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:kibana-react Feature:Storybook impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) technical debt Improvement of the software architecture and operational architecture v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@clintandrewhall @kibana-ci @kibanamachine @majagrubic @jbudz @ThomThomson @rshen91 @vadimkibana @spalger