Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Enable APM integration e2e tests #125724

Merged
merged 9 commits into from
Feb 18, 2022
Merged

[APM] Enable APM integration e2e tests #125724

merged 9 commits into from
Feb 18, 2022

Conversation

cauemarcondes
Copy link
Contributor

We no longer need to spin up the package registry alongside our FTR. Fleet has already implemented a workaround for when it is not available, so for us will be a matter of starting writing the tests.

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Feb 15, 2022
@cauemarcondes cauemarcondes marked this pull request as ready for review February 16, 2022 13:42
@cauemarcondes cauemarcondes requested a review from a team as a code owner February 16, 2022 13:42
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Feb 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #10 / Actions and Triggers app alerts list should mute single alert

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes enabled auto-merge (squash) February 17, 2022 18:18
sorenlouv
sorenlouv approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks for doing this @cauemarcondes

@cauemarcondes cauemarcondes merged commit 8e88efa into elastic:main Feb 18, 2022
@kibanamachine
Copy link
Contributor

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 125724

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 22, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125724 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125724 or prevent reminders by adding the backport:skip label.

@gbamparop
Copy link
Contributor

@cauemarcondes do you think this should be added on 8.1.0?. We could also add a backport:skip label to stop the reminders.

@cauemarcondes cauemarcondes removed backport missing Added to PRs automatically when the are determined to be missing a backport. auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 23, 2022
@cauemarcondes cauemarcondes added the backport:skip This commit does not require backporting label Feb 23, 2022
@cauemarcondes
Copy link
Contributor Author

@cauemarcondes do you think this should be added on 8.1.0?. We could also add a backport:skip label to stop the reminders.

Thanks @gbamparop I added it.

lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@cauemarcondes @kibanamachine @lucasfcosta
[APM] Enable APM integration e2e tests (elastic#125724)
30ab99e 
* removing package registry docker

* unused imports

* not used

* fixing ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cauemarcondes @elasticmachine @kibana-ci @kibanamachine @gbamparop @sorenlouv @tylersmalley