Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Jest configuration #125727

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Feb 15, 2022

Removes the root Jest configurations from the repository as it's are no longer needed after #125454. The root configuration should not be used as loading the entire project is too slow. yarn test:jest {path} or node scripts/jest {path} should be used instead. Or, you can pass a jest.config.js file directory to yarn jest or ./node_modules/.bin/jest.

Additionally:

  • resolved an issue where the node scripts/check_jest_configs doesn't exit with a non-zero exit code when a configuration file is missing.
  • updates the snapshot job to parallelize jest functional tests
  • correctly sets the Jest integration test config name so it will be picked up by scripts/jest_functional

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.1 v8.0.1 v8.1.0 v8.2.0 labels Feb 16, 2022
@tylersmalley tylersmalley marked this pull request as ready for review February 16, 2022 00:07
@tylersmalley tylersmalley requested a review from a team as a code owner February 16, 2022 00:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 16, 2022
@tylersmalley tylersmalley enabled auto-merge (squash) February 16, 2022 00:20
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that node scripts/jest_integration works, looks like all 208 Jest Unit configs and all 14 Integration configs are still running 👍

@tylersmalley tylersmalley merged commit e9d82d1 into elastic:main Feb 16, 2022
@tylersmalley tylersmalley deleted the jest-updates branch February 16, 2022 02:06
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 16, 2022
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.1
8.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.0:
- Adds nav link to uisettings tutorial (#125736)
7.17 Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 125727

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 16, 2022
(cherry picked from commit e9d82d1)

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Feb 16, 2022
(cherry picked from commit e9d82d1)

# Conflicts:
#	.buildkite/scripts/steps/code_coverage/jest.sh
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Feb 16, 2022
(cherry picked from commit e9d82d1)

# Conflicts:
#	.buildkite/scripts/steps/code_coverage/jest.sh
tylersmalley pushed a commit that referenced this pull request Feb 16, 2022
(cherry picked from commit e9d82d1)

# Conflicts:
#	.buildkite/scripts/steps/code_coverage/jest.sh
tylersmalley pushed a commit that referenced this pull request Feb 16, 2022
(cherry picked from commit e9d82d1)

# Conflicts:
#	.buildkite/scripts/steps/code_coverage/jest.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.1 v8.0.1 v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants