Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kibana_react] Deprecate ExitFullScreenButton in favor of new Shared UX component #125750

Merged
merged 1 commit into from
Feb 16, 2022
Merged

[kibana_react] Deprecate ExitFullScreenButton in favor of new Shared UX component #125750

merged 1 commit into from
Feb 16, 2022

Conversation

clintandrewhall
Copy link
Contributor

Summary

Related: #122556, #122499
Addresses: #114990

Since a revised ExitFullScreenButton was added to Shared UX, we can deprecate the existing component and notify consuming teams to migrate. Once complete, we can delete the existing component.

This PR deprecates the component, (and fixes a few minor issues and docs).

@clintandrewhall clintandrewhall added review Feature:Dashboard Dashboard related features [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:kibana-react v8.2.0 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Feb 16, 2022
@clintandrewhall clintandrewhall requested a review from a team as a code owner February 16, 2022 05:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

This was referenced Feb 16, 2022
Closed
Merged
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
sharedUX 8.5KB 8.5KB -12.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
sharedUX 3.7KB 3.8KB +50.0B
Unknown metric groups

ESLint disabled in files

id before after diff
sharedUX 3 2 -1

References to deprecated APIs

id before after diff
dashboard 77 81 +4
maps 453 455 +2
total +6

Total ESLint disabled count

id before after diff
sharedUX 4 3 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant
Dosant approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nreese nreese mentioned this pull request Feb 16, 2022
Closed
@clintandrewhall clintandrewhall merged commit 6ca15e5 into elastic:main Feb 16, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125750 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 18, 2022
@clintandrewhall clintandrewhall added the backport:skip This commit does not require backporting label Feb 20, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Dashboard Dashboard related features Feature:kibana-react impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clintandrewhall @elasticmachine @kibana-ci @kibanamachine @Dosant