Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps] Adds tooltip to time window selector in ES query rule flyout #125764

Merged
merged 13 commits into from
Feb 21, 2022
Merged

[ResponseOps] Adds tooltip to time window selector in ES query rule flyout #125764

Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1794f2f
[ResponseOps] Adds tooltip to time window selector in ES query rule UI.
szabosteve Feb 15, 2022
c53681e
Repositions tooltip.
szabosteve Feb 16, 2022
2afcb85
Merge branch 'main' into tooltip.for-the-last
szabosteve Feb 16, 2022
6c20fe8
Merge branch 'main' into tooltip.for-the-last
szabosteve Feb 16, 2022
907642b
Merge branch 'main' into tooltip.for-the-last
szabosteve Feb 16, 2022
979c2a8
Changes namespace for tooltip.
szabosteve Feb 16, 2022
7923d66
Merge branch 'tooltip.for-the-last' of github.com:szabosteve/kibana i…
szabosteve Feb 16, 2022
99ac7cf
Merge branch 'main' into tooltip.for-the-last
szabosteve Feb 16, 2022
69a5034
Merge branch 'main' into tooltip.for-the-last
szabosteve Feb 16, 2022
3a8e58e
Adjusts position of tooltip.
szabosteve Feb 17, 2022
ce96f85
Adjusts position of tooltip.
szabosteve Feb 17, 2022
9250f97
Merge branch 'main' into tooltip.for-the-last
szabosteve Feb 17, 2022
5330617
Merge branch 'main' into tooltip.for-the-last
kibanamachine Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions x-pack/plugins/stack_alerts/public/alert_types/es_query/expression.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,16 @@ import { XJsonMode } from '@kbn/ace';
import 'brace/theme/github';

import {
EuiFlexGroup,
EuiFlexItem,
EuiButtonEmpty,
EuiSpacer,
EuiFormRow,
EuiCallOut,
EuiText,
EuiTitle,
EuiLink,
EuiIconTip,
} from '@elastic/eui';
import { DocLinksStart, HttpSetup } from 'kibana/public';
import type * as estypes from '@elastic/elasticsearch/lib/api/typesWithBodyKey';
Expand Down Expand Up @@ -347,14 +350,31 @@ export const EsQueryAlertTypeExpression: React.FunctionComponent<
</EuiFormRow>
)}
<EuiSpacer />
<EuiTitle size="xs">
<h5>
<FormattedMessage
id="xpack.stackAlerts.esQuery.ui.conditionPrompt"
defaultMessage="When number of matches"
<EuiFlexGroup alignItems="center" responsive={false} gutterSize="none">
<EuiFlexItem grow={false}>
<EuiTitle size="xs">
<h5>
<FormattedMessage
id="xpack.stackAlerts.esQuery.ui.conditionPrompt"
defaultMessage="When number of matches"
/>
</h5>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiIconTip
position="right"
color="subdued"
type="questionInCircle"
iconProps={{
className: 'eui-alignTop',
}}
content={i18n.translate('xpack.stackAlerts.esQuery.ui.conditionPrompt.toolTip', {
defaultMessage: 'The time window defined below applies only to the first rule check.',
})}
/>
</h5>
</EuiTitle>
</EuiFlexItem>
</EuiFlexGroup>
<EuiSpacer size="s" />
<ThresholdExpression
data-test-subj="thresholdExpression"
Expand Down