Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.1] [Security Solution][Lists] - Fix exception list with comments import bug (#124909) #125807

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

kibanamachine
Copy link
Contributor

Backport

This is an automatic backport to 8.1 of:

Questions ?

Please refer to the Backport tool documentation

…bug (elastic#124909)

### Summary

Addresses elastic#124742

#### Issue TLDR
Import of rules that reference exception items with comments fail. Failure message states that comments cannot include `created_at`, `created_by`, `id`.

(cherry picked from commit f894d86)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lists 293 295 +2
securitySolution 2870 2872 +2
total +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/securitysolution-io-ts-list-types 428 434 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 140.3KB 140.5KB +202.0B
securitySolution 4.7MB 4.7MB +227.0B
total +429.0B
Unknown metric groups

API count

id before after diff
@kbn/securitysolution-io-ts-list-types 439 446 +7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@kibanamachine kibanamachine merged commit a71fcb7 into elastic:8.1 Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants