Update painless antlr grammar for fields API $-syntax #125818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$('fieldname', <default>) was added in elasticsearch/elastic#80518.
This updated the ANTLR grammar so that the syntax check
passes.
painless_lexer.g4 adapted from elasticsearch/modules/lang-painless/src/main/antlr/PainlessLexer.g4
painless_parser.g4 adapted from elasticsearch/modules/lang-painless/src/main/antlr/PainlessParser.g4
Generated by running `npm run build:antlr4ts` from `packages/kbn-monaco`
Related to elastic#84695
|
Before: After: |
alisonelizabeth
added
Feature:Painless Lab
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
|
@elasticmachine merge upstream |
alisonelizabeth
requested changes
Feb 16, 2022
There was a problem hiding this comment.
Thanks for working on this @stu-elastic! I think I found a regression, and left a couple comments about it. Let me know what you think. Thanks!
| @@ -184,13 +185,9 @@ export class painless_lexer extends Lexer { | |||
| // @Override | |||
| public sempred(_localctx: RuleContext, ruleIndex: number, predIndex: number): boolean { | |||
| switch (ruleIndex) { | |||
| // DO NOT CHANGE | |||
| // This is a manual fix to handle slashes appropriately | |||
| case 31: | |||
There was a problem hiding this comment.
I think we need to add this comment back in, and change it to 32 based on the addition of DOLLAR. Otherwise, the slash is broken again.
Long term, it would be nice to figure out the root of this problem 😄 (briefly explained in the readme).
There was a problem hiding this comment.
Nice find. Updated.
| case 31: | ||
| return this.DIV_sempred(_localctx, predIndex); | ||
|
|
||
| // DO NOT CHANGE | ||
| // This is a manual fix to handle regexes appropriately | ||
| case 77: |
There was a problem hiding this comment.
Similarly to above - I think we need to add this comment back in, and change it to 78 based on the addition of DOLLAR.
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
alisonelizabeth
approved these changes
Feb 17, 2022
stu-elastic
added a commit
to stu-elastic/kibana
that referenced
this pull request
Feb 17, 2022
$('fieldname', <default>) was added in elasticsearch/elastic#80518.
This updated the ANTLR grammar so that the syntax check
passes.
painless_lexer.g4 adapted from elasticsearch/modules/lang-painless/src/main/antlr/PainlessLexer.g4
painless_parser.g4 adapted from elasticsearch/modules/lang-painless/src/main/antlr/PainlessParser.g4
Generated by running `npm run build:antlr4ts` from `packages/kbn-monaco`
(cherry picked from commit ea6be3c)
stu-elastic
added a commit
that referenced
this pull request
Feb 17, 2022
) $('fieldname', <default>) was added in elasticsearch/#80518. This updated the ANTLR grammar so that the syntax check passes. painless_lexer.g4 adapted from elasticsearch/modules/lang-painless/src/main/antlr/PainlessLexer.g4 painless_parser.g4 adapted from elasticsearch/modules/lang-painless/src/main/antlr/PainlessParser.g4 Generated by running `npm run build:antlr4ts` from `packages/kbn-monaco` (cherry picked from commit ea6be3c)
KOTungseth
added
the
Feature:Data Views
tylersmalley
added
ci:cloud-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$('fieldname', <default>)was added in elasticsearch/80518.This change updates the ANTLR grammar so that the syntax check
passes.
painless_lexer.g4adapted fromelasticsearch/modules/lang-painless/src/main/antlr/PainlessLexer.g4painless_parser.g4adapted fromelasticsearch/modules/lang-painless/src/main/antlr/PainlessParser.g4Generated by running
npm run build:antlr4tsfrompackages/kbn-monacoRelated to #84695