Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kibana_react] Add 'sticky' rows-per-page using session storage to TableListView #126038

Conversation

clintandrewhall
Copy link
Contributor

Summary

Fixes #56406

It turns out that all of the pages that use TableListView from 'kibana_react already read the page size advanced setting from SavedObjects.settings (which is deprecated). This is a quick-and-dirty fix to make this sticky.

I may abandon this for a PR of larger scope, given this only makes this work for pages using this table and not some custom pagination solution.

@clintandrewhall clintandrewhall added release_note:enhancement WIP Work in progress loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v8.2.0 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Feb 21, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Feb 21, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Default CI Group #11 / detection engine api security and spaces enabled create_rules missing timestamps should create a single rule which has a timestamp override and generates two signals with a "partial failure" status
  • [job] [logs] Default CI Group #11 / detection engine api security and spaces enabled create_rules missing timestamps should create a single rule which has a timestamp override and generates two signals with a "partial failure" status
  • [job] [logs] Default CI Group #5 / rule registry spaces only: trial Rule Registry API with write permissions when creating a rule writes alerts data to the alert indices
  • [job] [logs] Default CI Group #5 / rule registry spaces only: trial Rule Registry API with write permissions when creating a rule writes alerts data to the alert indices
  • [job] [logs] Jest Tests #1 / TableListView render list view

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
kibanaReact 201 204 +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 56.5KB 56.7KB +238.0B
Unknown metric groups

API count

id before after diff
kibanaReact 236 239 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:enhancement Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.2.0 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a configuration setting for default "Rows Per Page" setting in Management
2 participants