[Logs UI] Remove reduces from Log Threshold Rule #126402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
release_note:fix
v8.0.0
Feature:Logs UI
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
klacabane
approved these changes
Feb 28, 2022
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
spalger
pushed a commit
that referenced
this pull request
Feb 28, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
simianhacker
added a commit
that referenced
this pull request
Feb 28, 2022
simianhacker
added a commit
that referenced
this pull request
Feb 28, 2022
simianhacker
added a commit
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the solution presented in #126304 by refactoring the
reducesto use afor/ofwith an outside accumulator. For the 8.x branch, this reduce the processing time from ~8 seconds to ~2 seconds. For the 7.x branch this will reduce the processing time for 30K groups from ~30 seconds to ~3 seconds. The data results are unchanged and everything should work as before.Closes #126304