-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FTR simulate mocha dry run #126702
FTR simulate mocha dry run #126702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, glad to see this wasn't too hard to implement and that you were able to keep it isolated so we can just remove it once Mocha fixes their implementation 👍
💚 Build SucceededMetrics [docs]Public APIs missing comments
Any counts in public APIs
To update your PR or re-run it, just comment with: cc @pheyos |
This PR works around a bug in mocha's dry run execution by collecting the tests without actually running mocha. (cherry picked from commit 954e3d3)
This PR works around a bug in mocha's dry run execution by collecting the tests without actually running mocha. (cherry picked from commit 954e3d3)
💔 Some backports could not be created
How to fixRe-run the backport manually:
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This PR works around a bug in mocha's dry run execution by collecting the tests without actually running mocha. (cherry picked from commit 954e3d3) # Conflicts: # packages/kbn-test/src/functional_test_runner/functional_test_runner.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Summary
This PR works around a bug in mocha's dry run execution by collecting the tests without actually running mocha.
Details
api_integration
suite and with the wholefunctional
suite to make sure it works for many entries