-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kbn/generate] add basic package generator #127095
Conversation
b373423
to
4562a65
Compare
5f5882f
to
cb5e5e1
Compare
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the BUILD.bazel file didn't get updates / templates didn't get written.
~/dev/kibana (pr/127095) » node scripts/generate package @kbn/test123 1 ↵ jon@xps
info Wrote plugin files to /home/jon/dev/kibana/packages/kbn-test123
info Updated package.json file
info Updated packages/BUILD.bazel
succ Generated @kbn/test123! Please bootstrap to make sure it works.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
~/dev/kibana (pr/127095*) » git status jon@xps
On branch pr/127095
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: package.json
no changes added to commit (use "git add" and/or "git commit -a")
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
~/dev/kibana (pr/127095*) » ls packages/kbn-test123 jon@xps
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
~/dev/kibana (pr/127095*) »
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nice to include these in the default template based on the tsconfig.json:
TYPES_DEPS = [
"@npm//@types/jest",
"@npm//@types/node",
]
Overall though LGTM
Sounds good, thanks! |
💚 Build SucceededMetrics [docs]Public APIs missing comments
Public APIs missing exports
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit ad0eb60) # Conflicts: # packages/BUILD.bazel # packages/kbn-pm/dist/index.js # packages/kbn-type-summarizer/src/lib/bazel_cli_config.ts
…re-browser-errors * 'main' of github.com:elastic/kibana: (46 commits) [Reporting] Capture Kibana stopped error (elastic#127017) add updatedAt to SimpleSavedObject (elastic#126359) Remove deprecated & unused `ElasticsearchServiceStart.legacy` (elastic#127050) remove opacity for fitting line series (elastic#127176) Remove deprecated & unused `HttpServiceSetup.auth` (elastic#127056) [Lens] Show underlying data editor navigation (elastic#125983) Bump dependencies (elastic#127238) Remove deprecated & unused `public-AsyncPlugin` (elastic#127048) Remove deprecated & unused `SavedObjectsImportFailure.title` (elastic#127043) skip flaky suite (elastic#123372) [kbn/generate] add basic package generator (elastic#127095) [build] Up compression quality (elastic#127064) Made fix to broken test. Deleted all existing pipelines before test starts. FLAKY: elastic#118593 (elastic#127102) Increase timeout for Jest integration tests (elastic#127220) skip failing test suite (elastic#126949) [DOCS] Adds note for data source performance impact (elastic#127184) [Security Solution] Adds CCS privileges warning enable switch in advanced settings (elastic#124459) [App Search] Move to tabbed single tabbed JSON flyout with upload and paste options and refactor cards (elastic#127162) Update dependency chromedriver to v99 (elastic#127079) [kbn/pm] add timings for more parts of bootstrap (elastic#127157) ... # Conflicts: # x-pack/plugins/reporting/common/errors/index.ts # x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
Adds a script for generating packages which uses the template at
packages/kbn-generate/templates/package
. The package CLI is pretty simple right now and has the following--help
text:The template at
packages/kbn-generate/templates/package
is used to create the package source files. After they're written to disk the package.json file is updated to include references to the new plugin (location based on the--dev
flag), and then thepackages/BUILD.bazel
file is regenerated by discovering all the packages in the repo and producing the new file.See @kbn/packages, a new package that I generated with this script and updated to discover packages and generate the shared
packages/BUILD.bazel
file.