[Lens] Drop partial buckets option #127153

dej611 · 2022-03-08T14:39:34Z

Summary

Fix #120128

This PR introduces the support of drop partial buckets in Lens.

This is an example effect of the feature enabled:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

dej611 · 2022-03-08T16:43:46Z

@elasticmachine merge upstream

elasticmachine · 2022-03-09T09:25:53Z

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

stratoula · 2022-03-09T09:33:10Z

As we are adding this functionality to Lens, we can also support the transition from TSVB to Lens with this setting.

flash1293 · 2022-03-09T10:49:17Z

This addition detaches the "Minimum interval" picker from the "Customize time interval" switch - should we flip the order to keep them together?

Also the switch should be disabled if "Bind to global time picker" is disabled - as there's no defined boundaries, there are no "partial buckets" anymore by definition (probably worth a tooltip explaining why that's the case)

dej611 · 2022-03-09T11:33:50Z

As we are adding this functionality to Lens, we can also support the transition from TSVB to Lens with this setting.

Technically the Lens feature is a bit wider than the TSVB one, allowing also to drop the first bucket where possible. It sounds reasonable to extents the feature in this case. What do you think @stratoula ?

stratoula · 2022-03-09T11:35:42Z

Agreed :)

…e/120128

dej611 · 2022-03-09T14:35:50Z

This addition detaches the "Minimum interval" picker from the "Customize time interval" switch - should we flip the order to keep them together?

Done.

Also the switch should be disabled if "Bind to global time picker" is disabled - as there's no defined boundaries, there are no "partial buckets" anymore by definition (probably worth a tooltip explaining why that's the case)

Done. When disabled the following tooltip will be displayed on the input:

Drop partial buckets is disabled as these can be computed only for time field bound to global time picker in the top right.

I didn't want to go too much in depth with the technical explanation, so I thought a practical explanation would be more helpful. Any suggestion to improve is welcome.

As we are adding this functionality to Lens, we can also support the transition from TSVB to Lens with this setting.

Done.

flash1293 · 2022-03-09T14:52:08Z

@elasticmachine merge upstream

…e/120128

stratoula · 2022-03-09T17:04:16Z

@dej611 I am so sorry that I didn't mention this into my previous comment but TSVB has the overwrite dataview functionality

You can have a global setting but also you can overwrite it per layer. The overwritten functionality is supported in the TSVB to Lens feature so I think we should also support the drop last bucket setting of a layer has the overwtite data view setting on.

dej611 · 2022-03-10T11:21:07Z

@elasticmachine merge upstream

flash1293

LGTM, works as expected

flash1293 · 2022-03-10T11:45:31Z

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/date_histogram.tsx

+              'xpack.lens.indexPattern.dateHistogram.dropPartialBucketsHelp',
+              {
+                defaultMessage:
+                  'Drop partial buckets is disabled as these can be computed only for time field bound to global time picker in the top right.',


nit: ...a time field...

stratoula

This works great Marco 👏 LGTM!

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/date_histogram.tsx

…definitions/date_histogram.tsx

kibana-ci · 2022-03-10T14:41:42Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`visualizations`	328	329	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	1.1MB	1.1MB	+1.0KB
`visTypeTimeseries`	470.2KB	470.3KB	+93.0B
total			+1.1KB

Unknown metric groups

API count

id	before	after	diff
`visualizations`	349	350	+1

History

💚 Build #29298 succeeded ec2cfda
💔 Build #29290 failed a6c5e68
💔 Build #28876 failed a1055c1
💔 Build #28821 failed 793c719
💚 Build #28462 succeeded 4018d92
💔 Build #28404 failed 21d94c3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…move-pdf-generation-to-screenshotting * 'main' of github.com:elastic/kibana: (62 commits) [Lens] Drop partial buckets option (elastic#127153) chore(NA): remove unused translation xpack.ml.management.jobsSpacesList.objectNoun from fr-FR (elastic#127457) Add data to user details page (elastic#127019) [Fleet] Make upload and registry package info consistent (elastic#126915) [Reporting] Capture browser errors (elastic#127135) Initial readme commit with some stub articles (elastic#127420) skip flaky suite (elastic#121482) skip flaky suite (elastic#127416) Tests to ensure Kibana is handling multi-space import of saved objects correctly (elastic#127229) [Aggs] remove toAngularJson (elastic#127267) [i18n] Integrate 8.2.0 Translations (elastic#127309) [Security Solution] [Endpoint] Creates generic policy tab artifact component to be used for all of our artifacts (elastic#126685) [Kibana React] Fix Page Template `solutionNav` propagation (elastic#127140) [Cases] Export getRelatedCases API from cases client (elastic#127065) [Cloud Posture]add support for sorting benchmark page (elastic#126983) [User experience] Fix filters for the app (elastic#127295) [Fleet] Fix timeserie dimension mapping (elastic#127328) [data view mgmt] fix data view name wrap (elastic#127319) [kbn/optimizer] extract string diffing logic (elastic#127394) [ResponseOps] Add pagination and sorting to the alerts search strategy (elastic#126813) ... # Conflicts: # x-pack/plugins/screenshotting/common/errors.ts # x-pack/plugins/screenshotting/common/index.ts # x-pack/plugins/screenshotting/server/screenshots/observable.ts

dej611 added 2 commits March 8, 2022 15:32

✨ Add drop partial buckets support in date histogram

e87e051

✅ Add tests

21d94c3

dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting v8.2.0 labels Mar 8, 2022

dej611 changed the title ~~[Lens] Drop first buckets option~~ [Lens] Drop partial buckets option Mar 8, 2022

✅ Fix borken unit tests

745b8e1

Merge branch 'main' into feature/120128

4018d92

dej611 added the release_note:enhancement label Mar 9, 2022

dej611 marked this pull request as ready for review March 9, 2022 09:25

dej611 requested a review from a team as a code owner March 9, 2022 09:25

dej611 added 4 commits March 9, 2022 12:35

💄 Changed switch order

4d28dc4

👌 Disable drop feature for unbound date field

dbf4257

✨ Extend feature to the tsvb2lens transition code

df7c1b5

Merge branch 'feature/120128' of github.com:dej611/kibana into featur…

efe5f00

…e/120128

kibanamachine and others added 3 commits March 9, 2022 09:52

Merge branch 'main' into feature/120128

793c719

✅ Fix tests

be71748

Merge branch 'feature/120128' of github.com:dej611/kibana into featur…

a1055c1

…e/120128

🐛 Support layer override in tsvb

a6c5e68

Merge branch 'main' into feature/120128

ec2cfda

flash1293 approved these changes Mar 10, 2022

View reviewed changes

stratoula approved these changes Mar 10, 2022

View reviewed changes

dej611 commented Mar 10, 2022

View reviewed changes

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/date_histogram.tsx Outdated Show resolved Hide resolved

Update x-pack/plugins/lens/public/indexpattern_datasource/operations/…

3ae7b2f

…definitions/date_histogram.tsx

dej611 merged commit d0b3c65 into elastic:main Mar 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lens] Drop partial buckets option #127153

[Lens] Drop partial buckets option #127153

dej611 commented Mar 8, 2022 •

edited

Loading

dej611 commented Mar 8, 2022

elasticmachine commented Mar 9, 2022

stratoula commented Mar 9, 2022

flash1293 commented Mar 9, 2022 •

edited

Loading

dej611 commented Mar 9, 2022

stratoula commented Mar 9, 2022

dej611 commented Mar 9, 2022

flash1293 commented Mar 9, 2022

stratoula commented Mar 9, 2022

dej611 commented Mar 10, 2022

flash1293 left a comment

flash1293 Mar 10, 2022

stratoula left a comment

kibana-ci commented Mar 10, 2022

API count

[Lens] Drop partial buckets option #127153

[Lens] Drop partial buckets option #127153

Conversation

dej611 commented Mar 8, 2022 • edited Loading

Summary

Checklist

Risk Matrix

For maintainers

dej611 commented Mar 8, 2022

elasticmachine commented Mar 9, 2022

stratoula commented Mar 9, 2022

flash1293 commented Mar 9, 2022 • edited Loading

dej611 commented Mar 9, 2022

stratoula commented Mar 9, 2022

dej611 commented Mar 9, 2022

flash1293 commented Mar 9, 2022

stratoula commented Mar 9, 2022

dej611 commented Mar 10, 2022

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 Mar 10, 2022

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

kibana-ci commented Mar 10, 2022

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

API count

History

dej611 commented Mar 8, 2022 •

edited

Loading

flash1293 commented Mar 9, 2022 •

edited

Loading