Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Isolate DataView code to the Kibana service implementation #127415

Closed

Conversation

clintandrewhall
Copy link
Contributor

Summary

This is a WIP/draft to isolate the use of DataView and startPlugins.dataViewEditor.openEditor to the kibana implementation of the service.

Why?

I'm going to be moving components and services to packages, and in order to do that, I have to isolate the Kibana implementations of our service abstractions so the components can exist in isolation themselves.

Open Questions

The only way I can get the EditorsServiceFactory to accept the method from startPlugins.dataViewEditor is to create a generic and default it to unknown. I'm curious if there's a better, cleaner way to do this...?

@clintandrewhall clintandrewhall added WIP Work in progress loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v8.2.0 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Mar 10, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Mar 10, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / on dataView created
  • [job] [logs] Jest Integration Tests #3 / Fleet preconfiguration reset Preconfigred cloud policy Create correct .fleet-policies

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
sharedUX 100.7KB 100.6KB -23.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.2.0 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants