[WIP] Isolate DataView code to the Kibana service implementation #127415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a WIP/draft to isolate the use of
DataView
andstartPlugins.dataViewEditor.openEditor
to thekibana
implementation of the service.Why?
I'm going to be moving components and services to packages, and in order to do that, I have to isolate the Kibana implementations of our service abstractions so the components can exist in isolation themselves.
Open Questions
The only way I can get the
EditorsServiceFactory
to accept the method fromstartPlugins.dataViewEditor
is to create a generic and default it tounknown
. I'm curious if there's a better, cleaner way to do this...?