Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP debug failing functional tests in 7.x #127596

Closed
wants to merge 2 commits into from
Closed

WIP debug failing functional tests in 7.x #127596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b05d8aa
WIP
Mar 14, 2022
3836477
Merge branch '7.16' into flaky-tests/legacy_SO_imports
gsoldevila Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/plugins/saved_objects_management/public/lib/resolve_saved_objects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,12 @@ export async function resolveSavedObjects(
}
}

// eslint-disable-next-line no-console
console.log(
'🚨 resolveSavedObjects(...)',
`conflictedIndexPatterns: ${conflictedIndexPatterns.length}; failedImports: ${failedImports.length}`
);

return {
conflictedIndexPatterns,
conflictedSavedObjectsLinkedToSavedSearches,
Expand Down
2 changes: 1 addition & 1 deletion test/functional/apps/dashboard/bwc_import.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const dashboardExpect = getService('dashboardExpect');

// https://github.com/elastic/kibana/issues/114053
describe.skip('bwc import', function describeIndexTests() {
describe('bwc import', function describeIndexTests() {
before(async function () {
await PageObjects.dashboard.initTests();
await PageObjects.settings.navigateTo();
Expand Down
80 changes: 40 additions & 40 deletions test/functional/apps/dashboard/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,49 +40,49 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
before(loadCurrentData);
after(unloadCurrentData);

loadTestFile(require.resolve('./empty_dashboard'));
loadTestFile(require.resolve('./url_field_formatter'));
loadTestFile(require.resolve('./embeddable_rendering'));
loadTestFile(require.resolve('./embeddable_data_grid'));
loadTestFile(require.resolve('./create_and_add_embeddables'));
loadTestFile(require.resolve('./edit_embeddable_redirects'));
loadTestFile(require.resolve('./dashboard_unsaved_state'));
loadTestFile(require.resolve('./dashboard_unsaved_listing'));
loadTestFile(require.resolve('./edit_visualizations'));
loadTestFile(require.resolve('./time_zones'));
loadTestFile(require.resolve('./dashboard_options'));
loadTestFile(require.resolve('./data_shared_attributes'));
loadTestFile(require.resolve('./share'));
loadTestFile(require.resolve('./embed_mode'));
loadTestFile(require.resolve('./dashboard_back_button'));
loadTestFile(require.resolve('./dashboard_error_handling'));
loadTestFile(require.resolve('./legacy_urls'));
loadTestFile(require.resolve('./saved_search_embeddable'));
// loadTestFile(require.resolve('./empty_dashboard'));
// loadTestFile(require.resolve('./url_field_formatter'));
// loadTestFile(require.resolve('./embeddable_rendering'));
// loadTestFile(require.resolve('./embeddable_data_grid'));
// loadTestFile(require.resolve('./create_and_add_embeddables'));
// loadTestFile(require.resolve('./edit_embeddable_redirects'));
// loadTestFile(require.resolve('./dashboard_unsaved_state'));
// loadTestFile(require.resolve('./dashboard_unsaved_listing'));
// loadTestFile(require.resolve('./edit_visualizations'));
// loadTestFile(require.resolve('./time_zones'));
// loadTestFile(require.resolve('./dashboard_options'));
// loadTestFile(require.resolve('./data_shared_attributes'));
// loadTestFile(require.resolve('./share'));
// loadTestFile(require.resolve('./embed_mode'));
// loadTestFile(require.resolve('./dashboard_back_button'));
// loadTestFile(require.resolve('./dashboard_error_handling'));
// loadTestFile(require.resolve('./legacy_urls'));
// loadTestFile(require.resolve('./saved_search_embeddable'));

// Note: This one must be last because it unloads some data for one of its tests!
// No, this isn't ideal, but loading/unloading takes so much time and these are all bunched
// to improve efficiency...
loadTestFile(require.resolve('./dashboard_query_bar'));
// loadTestFile(require.resolve('./dashboard_query_bar'));
});

describe('using current data', function () {
this.tags('ciGroup3');
before(loadCurrentData);
after(unloadCurrentData);

loadTestFile(require.resolve('./full_screen_mode'));
loadTestFile(require.resolve('./dashboard_filter_bar'));
loadTestFile(require.resolve('./dashboard_filtering'));
loadTestFile(require.resolve('./panel_expand_toggle'));
loadTestFile(require.resolve('./dashboard_grid'));
loadTestFile(require.resolve('./view_edit'));
loadTestFile(require.resolve('./dashboard_saved_query'));
// loadTestFile(require.resolve('./full_screen_mode'));
// loadTestFile(require.resolve('./dashboard_filter_bar'));
// loadTestFile(require.resolve('./dashboard_filtering'));
// loadTestFile(require.resolve('./panel_expand_toggle'));
// loadTestFile(require.resolve('./dashboard_grid'));
// loadTestFile(require.resolve('./view_edit'));
// loadTestFile(require.resolve('./dashboard_saved_query'));
// Order of test suites *shouldn't* be important but there's a bug for the view_edit test above
// https://github.com/elastic/kibana/issues/46752
// The dashboard_snapshot test below requires the timestamped URL which breaks the view_edit test.
// If we don't use the timestamp in the URL, the colors in the charts will be different.
loadTestFile(require.resolve('./dashboard_snapshots'));
loadTestFile(require.resolve('./embeddable_library'));
// loadTestFile(require.resolve('./dashboard_snapshots'));
// loadTestFile(require.resolve('./embeddable_library'));
});

// Each of these tests call initTests themselves, the way it was originally written. The above tests only load
Expand All @@ -93,25 +93,25 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
before(loadLogstash);
after(unloadLogstash);

loadTestFile(require.resolve('./dashboard_time_picker'));
loadTestFile(require.resolve('./bwc_shared_urls'));
// loadTestFile(require.resolve('./dashboard_time_picker'));
// loadTestFile(require.resolve('./bwc_shared_urls'));
loadTestFile(require.resolve('./bwc_import'));
loadTestFile(require.resolve('./panel_replacing'));
loadTestFile(require.resolve('./panel_cloning'));
loadTestFile(require.resolve('./copy_panel_to'));
loadTestFile(require.resolve('./panel_context_menu'));
loadTestFile(require.resolve('./dashboard_state'));
// loadTestFile(require.resolve('./panel_replacing'));
// loadTestFile(require.resolve('./panel_cloning'));
// loadTestFile(require.resolve('./copy_panel_to'));
// loadTestFile(require.resolve('./panel_context_menu'));
// loadTestFile(require.resolve('./dashboard_state'));
});

describe('using legacy data', function () {
this.tags('ciGroup5');
before(loadLogstash);
after(unloadLogstash);

loadTestFile(require.resolve('./dashboard_save'));
loadTestFile(require.resolve('./dashboard_time'));
loadTestFile(require.resolve('./dashboard_listing'));
loadTestFile(require.resolve('./dashboard_clone'));
// loadTestFile(require.resolve('./dashboard_save'));
// loadTestFile(require.resolve('./dashboard_time'));
// loadTestFile(require.resolve('./dashboard_listing'));
// loadTestFile(require.resolve('./dashboard_clone'));
});

// TODO: Remove when vislib is removed
Expand All @@ -135,7 +135,7 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
await browser.refresh();
});

loadTestFile(require.resolve('./dashboard_state'));
// loadTestFile(require.resolve('./dashboard_state'));
});
});
}
22 changes: 11 additions & 11 deletions test/functional/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,18 @@ export default async function ({ readConfigFile }) {

return {
testFiles: [
require.resolve('./apps/status_page'),
require.resolve('./apps/bundles'),
require.resolve('./apps/console'),
require.resolve('./apps/context'),
// require.resolve('./apps/status_page'),
// require.resolve('./apps/bundles'),
// require.resolve('./apps/console'),
// require.resolve('./apps/context'),
require.resolve('./apps/dashboard'),
require.resolve('./apps/dashboard_elements'),
require.resolve('./apps/discover'),
require.resolve('./apps/getting_started'),
require.resolve('./apps/home'),
require.resolve('./apps/management'),
require.resolve('./apps/saved_objects_management'),
require.resolve('./apps/visualize'),
// require.resolve('./apps/dashboard_elements'),
// require.resolve('./apps/discover'),
// require.resolve('./apps/getting_started'),
// require.resolve('./apps/home'),
// require.resolve('./apps/management'),
// require.resolve('./apps/saved_objects_management'),
// require.resolve('./apps/visualize'),
],
pageObjects,
services,
Expand Down