[SharedUX] Fix issue with services package; fix ExitFullScreenButton

[clintandrewhall]

Summary

This was a fun one.

First, @maksimkovalev and @nreese noticed a bug with ExitFullScreenButton where, when opting to toggleChrome, the chrome wasn't being hidden on mount. So this PR fixes that issue for #126055.

Second, with the recent changes to Shared UX to make it package-based, (#127546) the service context provided by src/plugins/shared_ux has stopped working in x-pack/plugins/maps.

Problem

Digging in, there was a lot of weirdness. A component wrapped with the context within the SharedUX plugin had access to the configured services. But a dependent plugin had a null context.

I messed with it for a few hours and was really starting to doubt my sanity. Talking it through with @spalger this morning, he supplied the answer:

Each plugin that imports a package gets its own copy of that package. That meant Shared UX and Maps were both importing their own copies of the hooks, but those hooks were referencing their own copy of the context.

As a result, providing a wired context as a part of the start contract of the Shared UX plugin meant only the hooks within Shared UX would be referencing the correct Context.

Solution

We have to tweak the API a bit. The Shared UX plugin can provide the configured services as a part of its start contract, but each plugin needs to provide those services to its local version of the SharedUxContextProvider:

import { SharedUxServicesProvider } from '@kbn/shared-ux-services';

public setup(coreSetup: CoreSetup, setupPlugins: MyPluginSetupDeps): MyPluginSetup {
  const [coreStart, startPlugins] = await coreSetup.getStartServices();

  coreSetup.application.register({
    mount: async (params: AppMountParameters) => {
      ReactDOM.render(
        <SharedUxServicesProvider {...startPlugins.sharedUX.getContextServices()}>
          <MyApp />
        </SharedUxServicesProvider>,
        params.element
      );
    }
  );
}

[clintandrewhall]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 1ff5767
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
sharedUX	28	11	-17

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
kibana	309	310	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
sharedUX	2.4KB	2.0KB	-437.0B

Unknown metric groups

API count

id	before	after	diff
sharedUX	6	4	-2

History

• 💔 Build #31634 failed ebfce18
• 💚 Build #31585 succeeded 2b8f605
• 💔 Build #31518 failed 406a2c7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[cchaos]

Found small typo 😄 SharedUsServicesProvider