Soc dashboard - UI #128087
Merged
Soc dashboard - UI #128087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
added
backport:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
/oblt-deploy |
jamster10
reviewed
Apr 20, 2022
| @@ -17,7 +17,7 @@ export const allowedExperimentalValues = Object.freeze({ | |||
| tGridEventRenderedViewEnabled: true, | |||
| excludePoliciesInFilterEnabled: false, | |||
| usersEnabled: true, | |||
| detectionResponseEnabled: false, | |||
| detectionResponseEnabled: true, | |||
There was a problem hiding this comment.
should this merge to main as true? Should the feature still be hidden or am I misunderstanding what this is for?
There was a problem hiding this comment.
Nah, it should be false, enabled it for deploying to cloud instance for design review, will remember to disable that
semd
reviewed
Apr 20, 2022
x-pack/plugins/security_solution/common/experimental_features.ts
Outdated
Show resolved
Hide resolved
semd
reviewed
Apr 20, 2022
x-pack/plugins/security_solution/public/common/components/charts/donutchart.tsx
Outdated
Show resolved
Hide resolved
…ts/donutchart.tsx Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>
|
@elasticmachine merge upstream |
merilmathew
approved these changes
Apr 21, 2022
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kqualters-elastic
approved these changes
Apr 21, 2022
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
* init pie chart * styling * donut card * styling * parser * wording * unit tests * disable detectionResponse feature flag * rename props * add detection_response folder * add query hook * disable detectionResponse * alerts button and count * toggle query * fix unit tests * disable dashboard * fillColor * disable dashboard * fix legends * detectionResponseEnabled * review * rm old tests * review * fix types * legend * rename * rm i18n keys * unit tests * update i18n keys * add unit tests * fix unit tests * review * review * styling * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * styling * styling * useEuiTheme * useEuiTheme * enable feature flag * disable flag * enable dashboard * disable dashboard * Update x-pack/plugins/security_solution/public/common/components/charts/donutchart.tsx Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com> * styling * styling * unit tests * unit tests * unit test * unit tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#127649
This UI is to render donut charts with alerts by status (mock) data.
It shows an empty donut if a bucket is missing:
Kapture.2022-04-08.at.02.36.18.mp4
Delete any items that are not applicable to this PR.