Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump React@17 #128239

Merged
merged 69 commits into from
Aug 22, 2022
Merged

Bump React@17 #128239

merged 69 commits into from
Aug 22, 2022

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Mar 22, 2022 •
edited
Loading

patrykkopycinski and others added 21 commits May 26, 2022 23:30
@patrykkopycinski patrykkopycinski changed the title Test Bump React@17 Jun 2, 2022
@patrykkopycinski patrykkopycinski mentioned this pull request Jun 2, 2022
Closed
11 tasks
@thompsongl thompsongl mentioned this pull request Jun 23, 2022
Closed
2 tasks
@nickofthyme nickofthyme linked an issue Jun 23, 2022 that may be closed by this pull request
Upgrade to react@^17 #129095
Closed
2 tasks
@patrykkopycinski
Merge branch 'main' of github.com:elastic/kibana into chore/react-17
bd80037 
# Conflicts:
#	package.json
#	x-pack/plugins/infra/public/containers/metrics_explorer/with_metrics_explorer_options_url_state.tsx
#	yarn.lock
@patrykkopycinski
lock
327888d
@patrykkopycinski
Merge branch 'main' of github.com:elastic/kibana into chore/react-17
e311926 
# Conflicts:
#	package.json
#	yarn.lock
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski enabled auto-merge (squash) August 21, 2022 20:56
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 5b7a8d8 into elastic:main Aug 22, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Alerts timeline Privileges: can crud should allow a user with crud privileges to attach alerts to cases

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1303 1309 +6
canvas 1148 1157 +9
controls 196 197 +1
core 361 368 +7
crossClusterReplication 136 138 +2
dashboard 361 371 +10
dataViewFieldEditor 136 139 +3
enterpriseSearch 1554 1567 +13
fleet 715 722 +7
graph 217 219 +2
indexManagement 482 487 +5
ingestPipelines 459 330 -129
kibanaReact 318 319 +1
kibanaUtils 161 168 +7
lens 891 893 +2
licenseManagement 127 129 +2
maps 919 922 +3
ml 1627 1600 -27
presentationUtil 183 185 +2
remoteClusters 120 122 +2
rollup 140 142 +2
security 416 423 +7
securitySolution 2984 2993 +9
synthetics 925 927 +2
timelines 251 253 +2
total -50

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 3.0MB +1.5KB
canvas 1.0MB 1.0MB +3.4KB
controls 443.7KB 440.7KB -3.1KB
core 136.4KB 146.2KB +9.8KB
crossClusterReplication 163.3KB 163.8KB +451.0B
dashboard 373.7KB 367.5KB -6.2KB
dataViewEditor 31.9KB 31.9KB -12.0B
dataViewFieldEditor 148.1KB 148.8KB +743.0B
enterpriseSearch 1.6MB 1.6MB +4.6KB
fleet 855.1KB 865.8KB +10.7KB
graph 410.5KB 411.0KB +453.0B
indexManagement 520.6KB 521.8KB +1.2KB
infra 1017.7KB 1016.5KB -1.1KB
ingestPipelines 452.9KB 431.5KB -21.5KB
kibanaReact 209.2KB 209.6KB +426.0B
kibanaUtils 51.7KB 61.5KB +9.8KB
lens 1.2MB 1.2MB +76.0B
licenseManagement 61.2KB 61.6KB +451.0B
maps 2.6MB 2.6MB +837.0B
ml 3.3MB 3.3MB -20.7KB
monitoring 479.1KB 478.0KB -1.1KB
observability 506.8KB 509.5KB +2.7KB
presentationUtil 127.6KB 128.0KB +453.0B
remoteClusters 83.5KB 83.9KB +451.0B
rollup 129.1KB 129.5KB +451.0B
security 503.6KB 513.4KB +9.8KB
securitySolution 5.3MB 5.4MB +11.8KB
synthetics 915.6KB 917.0KB +1.4KB
total +17.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 349.8KB 349.7KB -32.0B
globalSearchBar 20.5KB 20.5KB +17.0B
interactiveSetup 58.5KB 58.4KB -159.0B
kbnUiSharedDeps-npmDll 5.0MB 5.0MB -1.0KB
kibanaUtils 68.9KB 68.8KB -93.0B
security 52.1KB 51.9KB -158.0B
securitySolution 255.0KB 255.5KB +452.0B
timelines 258.4KB 258.8KB +453.0B
total -580.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 22, 2022
@patrykkopycinski patrykkopycinski deleted the chore/react-17 branch August 22, 2022 07:48
@mbondyra mbondyra mentioned this pull request Aug 30, 2022
Closed
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@patrykkopycinski @Mpdreamz
Bump React@17 (elastic#128239)
0752bdb
@Heenawter Heenawter mentioned this pull request Dec 19, 2022
Merged
2 tasks
Heenawter added a commit that referenced this pull request Jan 9, 2023
@Heenawter @kibanamachine
[Dashboard] Add styling to allow clickable TSVB markdown images (#147802
eaa9423 
)

## Summary

After upgrading to [React
17](#128239), the old version of
`react-grid-layout` was no longer compatible and required an upgrade as
well. However, this upgrade included a
[PR](react-grid-layout/react-grid-layout#1283)
that overcame a visual glitch with images, which made it so that a
clickable image in TSVB markdown was only clickable in a small region at
the bottom of the image.

This PR fixes this by undoing the changes made in the aforementioned
[PR](react-grid-layout/react-grid-layout#1283)
specifically for TSVB markdown images.

### Videos

**Before**


https://user-images.githubusercontent.com/8698078/208514574-e586c1e0-3675-4ef2-9a42-9956f81dee5a.mov


**After**


https://user-images.githubusercontent.com/8698078/208514585-353a0413-7ed2-40f9-8e90-8289b5483ecb.mov



### Checklist

- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 9, 2023
@Heenawter
[Dashboard] Add styling to allow clickable TSVB markdown images (elas…
3cc12f4 
…tic#147802)

## Summary

After upgrading to [React
17](elastic#128239), the old version of
`react-grid-layout` was no longer compatible and required an upgrade as
well. However, this upgrade included a
[PR](react-grid-layout/react-grid-layout#1283)
that overcame a visual glitch with images, which made it so that a
clickable image in TSVB markdown was only clickable in a small region at
the bottom of the image.

This PR fixes this by undoing the changes made in the aforementioned
[PR](react-grid-layout/react-grid-layout#1283)
specifically for TSVB markdown images.

### Videos

**Before**

https://user-images.githubusercontent.com/8698078/208514574-e586c1e0-3675-4ef2-9a42-9956f81dee5a.mov

**After**

https://user-images.githubusercontent.com/8698078/208514585-353a0413-7ed2-40f9-8e90-8289b5483ecb.mov

### Checklist

- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit eaa9423)
kibanamachine added a commit that referenced this pull request Jan 9, 2023
@kibanamachine @Heenawter
[8.6] [Dashboard] Add styling to allow clickable TSVB markdown images (…
8debf86 
…#147802) (#148586)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Dashboard] Add styling to allow clickable TSVB markdown images
(#147802)](#147802)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Hannah
Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-01-09T18:27:56Z","message":"[Dashboard]
Add styling to allow clickable TSVB markdown images (#147802)\n\n##
Summary\r\n\r\nAfter upgrading to
[React\r\n17](#128239), the old
version of\r\n`react-grid-layout` was no longer compatible and required
an upgrade as\r\nwell. However, this upgrade included
a\r\n[PR](https://github.com/react-grid-layout/react-grid-layout/pull/1283)\r\nthat
overcame a visual glitch with images, which made it so that
a\r\nclickable image in TSVB markdown was only clickable in a small
region at\r\nthe bottom of the image.\r\n\r\nThis PR fixes this by
undoing the changes made in the
aforementioned\r\n[PR](https://github.com/react-grid-layout/react-grid-layout/pull/1283)\r\nspecifically
for TSVB markdown images.\r\n\r\n###
Videos\r\n\r\n**Before**\r\n\r\n\r\nhttps://user-images.githubusercontent.com/8698078/208514574-e586c1e0-3675-4ef2-9a42-9956f81dee5a.mov\r\n\r\n\r\n**After**\r\n\r\n\r\nhttps://user-images.githubusercontent.com/8698078/208514585-353a0413-7ed2-40f9-8e90-8289b5483ecb.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"eaa9423d51c043a9a6f4640cee26490b6d817dea","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Platform-Design","Feature:Dashboard","release_note:fix","Team:Presentation","loe:hours","Team:Visualizations","impact:low","backport:prev-minor","v8.7.0"],"number":147802,"url":"https://github.com/elastic/kibana/pull/147802","mergeCommit":{"message":"[Dashboard]
Add styling to allow clickable TSVB markdown images (#147802)\n\n##
Summary\r\n\r\nAfter upgrading to
[React\r\n17](#128239), the old
version of\r\n`react-grid-layout` was no longer compatible and required
an upgrade as\r\nwell. However, this upgrade included
a\r\n[PR](https://github.com/react-grid-layout/react-grid-layout/pull/1283)\r\nthat
overcame a visual glitch with images, which made it so that
a\r\nclickable image in TSVB markdown was only clickable in a small
region at\r\nthe bottom of the image.\r\n\r\nThis PR fixes this by
undoing the changes made in the
aforementioned\r\n[PR](https://github.com/react-grid-layout/react-grid-layout/pull/1283)\r\nspecifically
for TSVB markdown images.\r\n\r\n###
Videos\r\n\r\n**Before**\r\n\r\n\r\nhttps://user-images.githubusercontent.com/8698078/208514574-e586c1e0-3675-4ef2-9a42-9956f81dee5a.mov\r\n\r\n\r\n**After**\r\n\r\n\r\nhttps://user-images.githubusercontent.com/8698078/208514585-353a0413-7ed2-40f9-8e90-8289b5483ecb.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"eaa9423d51c043a9a6f4640cee26490b6d817dea"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147802","number":147802,"mergeCommit":{"message":"[Dashboard]
Add styling to allow clickable TSVB markdown images (#147802)\n\n##
Summary\r\n\r\nAfter upgrading to
[React\r\n17](#128239), the old
version of\r\n`react-grid-layout` was no longer compatible and required
an upgrade as\r\nwell. However, this upgrade included
a\r\n[PR](https://github.com/react-grid-layout/react-grid-layout/pull/1283)\r\nthat
overcame a visual glitch with images, which made it so that
a\r\nclickable image in TSVB markdown was only clickable in a small
region at\r\nthe bottom of the image.\r\n\r\nThis PR fixes this by
undoing the changes made in the
aforementioned\r\n[PR](https://github.com/react-grid-layout/react-grid-layout/pull/1283)\r\nspecifically
for TSVB markdown images.\r\n\r\n###
Videos\r\n\r\n**Before**\r\n\r\n\r\nhttps://user-images.githubusercontent.com/8698078/208514574-e586c1e0-3675-4ef2-9a42-9956f81dee5a.mov\r\n\r\n\r\n**After**\r\n\r\n\r\nhttps://user-images.githubusercontent.com/8698078/208514585-353a0413-7ed2-40f9-8e90-8289b5483ecb.mov\r\n\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n###
For maintainers\r\n\r\n- [ ] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"eaa9423d51c043a9a6f4640cee26490b6d817dea"}}]}]
BACKPORT-->

Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Jan 13, 2023
@Heenawter @kibanamachine @jennypavlova
[Dashboard] Add styling to allow clickable TSVB markdown images (elas…
9458af6 
…tic#147802)

## Summary

After upgrading to [React
17](elastic#128239), the old version of
`react-grid-layout` was no longer compatible and required an upgrade as
well. However, this upgrade included a
[PR](react-grid-layout/react-grid-layout#1283)
that overcame a visual glitch with images, which made it so that a
clickable image in TSVB markdown was only clickable in a small region at
the bottom of the image.

This PR fixes this by undoing the changes made in the aforementioned
[PR](react-grid-layout/react-grid-layout#1283)
specifically for TSVB markdown images.

### Videos

**Before**


https://user-images.githubusercontent.com/8698078/208514574-e586c1e0-3675-4ef2-9a42-9956f81dee5a.mov


**After**


https://user-images.githubusercontent.com/8698078/208514585-353a0413-7ed2-40f9-8e90-8289b5483ecb.mov



### Checklist

- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl left review comments

@tsullivan tsullivan tsullivan left review comments

@efegurkan efegurkan efegurkan approved these changes

@kertal kertal kertal approved these changes

@spalger spalger spalger approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

@thomheymann thomheymann thomheymann approved these changes

@cqliu1 cqliu1 cqliu1 approved these changes

@mattkime mattkime mattkime approved these changes

@mbondyra mbondyra mbondyra approved these changes

@vitaliidm vitaliidm vitaliidm approved these changes

@Bamieh Bamieh Bamieh approved these changes

@walterra walterra walterra approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@angorayc angorayc angorayc approved these changes

@sebelga sebelga sebelga approved these changes

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@cnasikas cnasikas cnasikas approved these changes

@matschaffer matschaffer matschaffer approved these changes

@kpollich kpollich kpollich approved these changes

@parkiino parkiino Awaiting requested review from parkiino parkiino was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

Assignees

@patrykkopycinski patrykkopycinski

Labels
backport:skip This commit does not require backporting ci:all-cypress-suites ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to react@^17