Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Add UI indicators for rules with less than configured minimum schedule interval #128254

Merged
merged 12 commits into from
Mar 24, 2022
Merged

[Alerting] Add UI indicators for rules with less than configured minimum schedule interval #128254

merged 12 commits into from
Mar 24, 2022

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Mar 22, 2022 •
edited
Loading

Resolves #126409

Summary

  • Adds info indicator on rules list for rules that are configured to run below the minimumScheduleInterval
  • If user is able to edit this rule, clicking on this indicator will open the Edit rule flyout
  • Adds info toast to rule details page on load for rules that are configured to run below the minimumScheduleInterval
  • If user is able to edit this rule, toast will include action button that, when clicked, opens the Edit rule flyout
Mar-22-2022.16-35-05.mp4

Checklist

@ymao1 ymao1 changed the title Adding warning icon next to rule interval [Alerting] Add UI indicators for rules with less than configured minimum schedule interval Mar 22, 2022
@ymao1 ymao1 self-assigned this Mar 22, 2022
@ymao1 ymao1 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.2.0 labels Mar 22, 2022
@ymao1 ymao1 marked this pull request as ready for review March 23, 2022 13:50
@ymao1 ymao1 requested a review from a team as a code owner March 23, 2022 13:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1 ymao1 requested a review from mdefazio March 23, 2022 13:51
mdefazio
mdefazio requested changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the request! A few small edits!

...plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list.tsx Outdated Show resolved Hide resolved
...plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list.tsx Outdated Show resolved Hide resolved
@ymao1
Copy link
Contributor Author

ymao1 commented Mar 23, 2022

@mdefazio Addressed your comments in this commit: efeabed

Updated screenshot:
Screen Shot 2022-03-23 at 2 53 42 PM

@ymao1 ymao1 requested a review from mdefazio March 23, 2022 18:55
mdefazio
mdefazio approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! LGTM

@ymao1
Copy link
Contributor Author

ymao1 commented Mar 24, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
triggersActionsUi 277 278 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 663.2KB 666.5KB +3.3KB
Unknown metric groups

API count

id before after diff
triggersActionsUi 289 290 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@mikecote mikecote self-requested a review March 24, 2022 13:31
pmuellr
pmuellr approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mikecote
mikecote approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM!

@ymao1 ymao1 merged commit a3e3ce8 into elastic:main Mar 24, 2022
@ymao1 ymao1 deleted the alerting/ux-minimum-rule-interval-2 branch March 24, 2022 13:53
@ymao1 ymao1 mentioned this pull request Mar 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdefazio mdefazio mdefazio approved these changes

@mikecote mikecote mikecote approved these changes

@pmuellr pmuellr pmuellr approved these changes

Assignees

@ymao1 ymao1

Labels
backport:skip This commit does not require backporting Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ResponseOps] UX for rules where interval is less than configured minimum
7 participants
@ymao1 @elasticmachine @kibana-ci @pmuellr @mikecote @mdefazio @kibanamachine