Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken/missing APM app links and use docLinks service #128326

Merged
merged 22 commits into from
May 4, 2022

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Mar 22, 2022

Summary

This PR updates two APM app links:

  • The Settings > Custom Links empty state text was missing a doc link. A new link has been added using the docLinks service.
  • The Settings > Schema Elastic Agent link was a 404. The link has been fixed and swapped to the docLinks service to prevent broken links in the future.

Related

Screenshots

Screen Shot 2022-03-22 at 4 18 21 PM

Screen Shot 2022-03-22 at 4 18 36 PM

@bmorelli25 bmorelli25 added release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Mar 22, 2022
@bmorelli25 bmorelli25 self-assigned this Mar 22, 2022
@bmorelli25 bmorelli25 marked this pull request as ready for review March 23, 2022 18:55
@bmorelli25 bmorelli25 requested review from a team as code owners March 23, 2022 18:55
@bmorelli25 bmorelli25 added Team:APM All issues that need APM UI Team support backport:skip This commit does not require backporting labels Mar 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@bmorelli25
Copy link
Member Author

I cannot for the life of me figure out how to fix these failing tests. Any help is greatly appreciated 😃

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tweaked the empty prompt message text to match what we've been doing in other places in the Kibana docs/UI, but otherwise, LGTM!

…empty_prompt.tsx

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
@bmorelli25
Copy link
Member Author

@elasticmachine merge upstream

@bmorelli25
Copy link
Member Author

bmorelli25 commented Apr 5, 2022

@elastic/apm-ui can someone help me out with these failing tests? Based on the error, I found these docs, but I can't figure out how to get shallowWithIntl() to work.

I was able to fix the CustomLink invalid license doesnt show license prompt when user has a trial license by updating to the code below. But I have no idea if this is the right way to do this, and I also can't make the fix work for the other failures.

- const component = render(
+ const component = shallowWithIntl(
    <LicenseContext.Provider value={license}>
      <MockApmPluginContextWrapper>
        <CustomLinkOverview />
      </MockApmPluginContextWrapper>
    </LicenseContext.Provider>
  );
- expectTextsNotInDocument(component, ['Start free 30-day trial']);
+ expect(component).toEqual(
+   expect.not.stringContaining('Start free 30-day trial')
+ );

bmorelli25 and others added 2 commits May 3, 2022 11:45
# Conflicts:
#	x-pack/plugins/apm/public/components/app/settings/schema/schema_overview.tsx
Co-authored-by: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co>
@bmorelli25 bmorelli25 added v8.2.1 auto-backport Deprecated - use backport:version if exact versions are needed and removed v8.2.0 backport:skip This commit does not require backporting labels May 4, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +296.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 289.3KB 289.3KB +62.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bmorelli25

@bmorelli25 bmorelli25 merged commit 860261c into elastic:main May 4, 2022
@bmorelli25 bmorelli25 deleted the fix-apm-links branch May 4, 2022 20:51
@kibanamachine
Copy link
Contributor

kibanamachine commented May 4, 2022

💔 All backports failed

Status Branch Result
8.2 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 128326

Questions ?

Please refer to the Backport tool documentation

Backported in #131656

bmorelli25 added a commit that referenced this pull request May 5, 2022
…28326) (#131656)

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128326 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 6, 2022
@bmorelli25 bmorelli25 removed backport missing Added to PRs automatically when the are determined to be missing a backport. auto-backport Deprecated - use backport:version if exact versions are needed labels May 6, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128326 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 9, 2022
@bmorelli25 bmorelli25 removed backport missing Added to PRs automatically when the are determined to be missing a backport. v8.2.1 labels May 9, 2022
@bmorelli25
Copy link
Member Author

Not sure how to make it stop. This was backported in #131656.

@gbamparop gbamparop added the backport:skip This commit does not require backporting label May 10, 2022
@gbamparop
Copy link
Contributor

Not sure how to make it stop. This was backported in #131656.

I think it needed a label, added the backport:skip.

kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
…128326)

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken APM app links
7 participants