-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken/missing APM app links and use docLinks
service
#128326
Conversation
Pinging @elastic/apm-ui (Team:apm) |
I cannot for the life of me figure out how to fix these failing tests. Any help is greatly appreciated 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tweaked the empty prompt message text to match what we've been doing in other places in the Kibana docs/UI, but otherwise, LGTM!
x-pack/plugins/apm/public/components/app/settings/custom_link/empty_prompt.tsx
Outdated
Show resolved
Hide resolved
…empty_prompt.tsx Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
@elasticmachine merge upstream |
@elastic/apm-ui can someone help me out with these failing tests? Based on the error, I found these docs, but I can't figure out how to get I was able to fix the - const component = render(
+ const component = shallowWithIntl(
<LicenseContext.Provider value={license}>
<MockApmPluginContextWrapper>
<CustomLinkOverview />
</MockApmPluginContextWrapper>
</LicenseContext.Provider>
);
- expectTextsNotInDocument(component, ['Start free 30-day trial']);
+ expect(component).toEqual(
+ expect.not.stringContaining('Start free 30-day trial')
+ ); |
# Conflicts: # x-pack/plugins/apm/public/components/app/settings/schema/schema_overview.tsx
Co-authored-by: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co>
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @bmorelli25 |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation Backported in #131656 |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Not sure how to make it stop. This was backported in #131656. |
I think it needed a label, added the |
…128326) Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co>
Summary
This PR updates two APM app links:
docLinks
service.docLinks
service to prevent broken links in the future.Related
Screenshots