Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Solution: Fix rule creation UI perf #128953

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

oatkiller
Copy link
Contributor

@oatkiller oatkiller commented Mar 30, 2022

Summary

Porting #128909 into main. This is an urgent fix that effects 8.1.0, 8.1.1, 8.1.2, 8.2.0 (main.) So I made the fix in the 8.1 branch first.

See the performance videos and benchmarching from the old PR. The behavior is similar on main. Without this fix, and with 14k fields in the dataview, the rule edit/create flow is unusable and the browser will report 'nonresponsive' errors to the user.

For maintainers

@oatkiller oatkiller enabled auto-merge (squash) March 30, 2022 17:48
@oatkiller oatkiller merged commit 14de388 into elastic:main Mar 30, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB -4.0B
Unknown metric groups

ESLint disabled in files

id before after diff
apm 15 14 -1
osquery 5 4 -1
securitySolution 69 68 -1
uptime 7 6 -1
total -4

ESLint disabled line counts

id before after diff
apm 88 85 -3
enterpriseSearch 9 7 -2
fleet 47 46 -1
osquery 122 119 -3
uptime 49 43 -6
total -15

References to deprecated APIs

id before after diff
canvas 70 64 -6
dashboard 78 72 -6
data 475 465 -10
dataEnhanced 55 49 -6
discover 26 20 -6
fleet 20 19 -1
lens 18 14 -4
management 2 1 -1
maps 456 330 -126
monitoring 40 28 -12
upgradeAssistant 12 7 -5
visDefaultEditor 205 155 -50
visTypeVega 4 3 -1
visualizations 17 13 -4
total -238

Total ESLint disabled count

id before after diff
apm 103 99 -4
enterpriseSearch 9 7 -2
fleet 55 54 -1
osquery 127 123 -4
securitySolution 509 508 -1
uptime 56 49 -7
total -19

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@oatkiller
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

oatkiller pushed a commit to oatkiller/kibana that referenced this pull request Mar 31, 2022
@oatkiller oatkiller deleted the fix-rule-creation-main branch March 31, 2022 11:00
oatkiller pushed a commit that referenced this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants