[Console] Add Kibana APIs Support #130816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
added
chore
Feature:Console
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
|
Verified in flaky test runner 50x - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/505 |
cjcenizal
approved these changes
Apr 21, 2022
3 tasks
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
* Revert "Revert "[Console] Add Kibana APIs Support (elastic#128562)"" This reverts commit f41dc1f. * fix functional test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the revert f41dc1f and fixes the failing functional test.
The majority of this code was already reviewed in #128562, however, the initial PR was reverted due to failing test on CI. The failing test was fixed via 27eaa95.
Why was the test failing?
The
enterRequest()console page helper was updated in the Kibana APIS support work to excludeawait textArea.pressKeys(Key.ENTER);. However, the test added via #126881 wasn't updated to expect this new behavior. I'm guessing #126881 was merged, but the Kibana APIs feature branch wasn't updated, and the code became out of sync and CI didn't catch the failure.Note: I'm skipping release notes, as I think the original PR can still be referenced for that.