Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose refresh option to SavedObjectsImporter #131339

Merged
merged 1 commit into from
May 3, 2022
Merged

Expose refresh option to SavedObjectsImporter #131339

merged 1 commit into from
May 3, 2022

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented May 2, 2022 •
edited
Loading

Summary

Adds the ability to set the refresh setting on the _bulk API call to Elasticsearch when importing saved objects via the SavedObjectImporter class. This will help us improve the performance of Integration package installation time significantly for packages with large numbers of SOs.

For example, the AWS package contains ~200 SOs and the bulk API call takes nearly 4 seconds:
image

Using refresh: false allowed me to shave off about 2.5 seconds:

image

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels May 2, 2022
@joshdover joshdover requested a review from a team as a code owner May 2, 2022 15:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

API count

id before after diff
core 2524 2525 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover mentioned this pull request May 2, 2022
Merged
pgayvallet
pgayvallet approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshdover joshdover merged commit 1c47b23 into elastic:main May 3, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 3, 2022
academo pushed a commit to academo/kibana that referenced this pull request May 4, 2022
@joshdover
Add refresh option to SavedObjectsImporter (elastic#131339)
24496bd
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@joshdover @kertal
Add refresh option to SavedObjectsImporter (elastic#131339)
362039c
@joshdover joshdover mentioned this pull request Jul 27, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshdover @elasticmachine @kibana-ci @pgayvallet @kibanamachine