-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add support for allow_routing data streams option #131609
Conversation
6dfe4fb
to
4ceb955
Compare
@@ -98,6 +98,7 @@ export async function storedPackagePoliciesToAgentPermissions( | |||
type: stream.data_stream.type, | |||
dataset: | |||
stream.compiled_stream?.data_stream?.dataset ?? stream.data_stream.dataset, | |||
allow_routing: stream.data_stream.allow_routing, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is going to give privileges on data streams outside of the ones of this package, shall we warn the user when this privilege is given? Otherwise any package could use this setting to inadvertently obtain too much privileges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea. Do you have a suggestion on how and were to warn the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that this would need to be done when installing a package with this flag enabled.
4ceb955
to
d67bef4
Compare
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
I updated this PR with the latest changes from #115032 I didn't quite get it to work yet with the correct permissions ending up in the resulting policy, but I think there's an issue with my test package. I will follow up on this by EOW. |
Thanks for picking this up, Josh. What are the next steps here? |
There's some conflicts between this and other work for input packages that we're working through. It also seems there's additional code paths that are fetching details from the registry that we need to remove to unblock this and input packages. I'm working with @hop-dev in #143198 to find a solution. |
Already implemented |
Summary
Explores adding support for elastic/package-spec#327, but it turns out we need to do #115032 first.
Doesn't work yet.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers