Optimize package installation performance, phase 2 #131627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
release_note:enhancement
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
kpollich
previously approved these changes
May 5, 2022
joshdover
dismissed
kpollich’s stale review
I've significantly refactored index template and ingest pipeline code to separate generating the assets form installing them. PTAL
joshdover
commented
May 6, 2022
Comment on lines
+149
to
+157
| /** | ||
| * In order to install assets in parallel, we need to split the preparation step from the installation step. This | ||
| * allows us to know which asset references are going to be installed so that we can save them on the packages | ||
| * SO before installation begins. In the case of a failure during installing any individual asset, we'll have the | ||
| * references necessary to remove any assets in that were successfully installed during the rollback phase. | ||
| * | ||
| * This split of prepare/install could be extended to all asset types. Besides performance, it also allows us to | ||
| * more easily write unit tests against the asset generation code without needing to mock ES responses. | ||
| */ |
There was a problem hiding this comment.
@kpollich Here would be a good place to start reviewing the latest commit / refactor
There was a problem hiding this comment.
Thanks - super helpful comment here so much appreciated on that.
joshdover
commented
May 6, 2022
| expect(sentTemplate?.index_patterns).toEqual([templateIndexPatternDatasetIsPrefixTrue]); | ||
| }); | ||
|
|
||
| it('tests installPackage remove the aliases property if the property existed', async () => { |
There was a problem hiding this comment.
I removed this whole test because this behavior is no longer necessary and was removed in the previous PR. This test just happens to still pass.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kpollich
approved these changes
May 6, 2022
Comment on lines
+149
to
+157
| /** | ||
| * In order to install assets in parallel, we need to split the preparation step from the installation step. This | ||
| * allows us to know which asset references are going to be installed so that we can save them on the packages | ||
| * SO before installation begins. In the case of a failure during installing any individual asset, we'll have the | ||
| * references necessary to remove any assets in that were successfully installed during the rollback phase. | ||
| * | ||
| * This split of prepare/install could be extended to all asset types. Besides performance, it also allows us to | ||
| * more easily write unit tests against the asset generation code without needing to mock ES responses. | ||
| */ |
There was a problem hiding this comment.
Thanks - super helpful comment here so much appreciated on that.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 9, 2022
…hromium-to-print-pdf-part-1 * 'main' of github.com:elastic/kibana: (59 commits) [Cloud Posture] Enabled findings group by feature (elastic#131780) [EBT] Fix `userId` generation (elastic#131701) [RAM] Add shareable rule tag filter (elastic#130710) Optimize package installation performance, phase 2 (elastic#131627) [Screenshotting] instrument for benchmark tests using new EventLogger class (elastic#130356) [Connector] Adding internal route for requesting ad-hoc ServiceNow access token (elastic#131171) [ci] bump kibana-buildkite-library (elastic#131754) [Synthetics] UI clean up (elastic#131598) [RsponseOps] Fix flaky rules list test (elastic#131567) [Cases] Add severity field to create case (elastic#131626) [Discover] Monospace font in Document Explorer (elastic#131513) Sessions tab improvements (elastic#131583) Add cloud icon "ess-icon" at the end of the config keys in "alerting" documentation (elastic#131735) [DOCS] Updates deprecation text for legacy APIs (elastic#131741) [ci] break out skip patterns so they can change without triggering CI (elastic#131726) Adjust search session management page font size (elastic#131291) [Unified search] Fix uptime css problem (elastic#131730) [Actionable Observability] Link to filtered rules page (elastic#131629) Add openAPI specifications for cases endpoint (elastic#131275) Display rule API key owner to users who can manage API keys (elastic#131662) ... # Conflicts: # x-pack/plugins/screenshotting/server/formats/pdf/index.ts # x-pack/plugins/screenshotting/server/screenshots/observable.ts
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up from #130906
Closes #110500
This makes two additional performance improvements to shave off several more seconds from the installation process:
refresh: falseon the Saved Object import of Kibana assets