Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Fix job completion notification to disappear after 24 hours #133381

Merged
merged 1 commit into from
Jun 2, 2022
Merged

[Reporting] Fix job completion notification to disappear after 24 hours #133381

merged 1 commit into from
Jun 2, 2022

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Jun 2, 2022

Summary

Resolves #133351.

Checklist

@dokmic dokmic added review (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes Team:AppServicesUx v8.4.0 labels Jun 2, 2022
@dokmic dokmic requested review from a team as code owners June 2, 2022 10:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 42.1KB 42.1KB -11.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tsullivan
tsullivan reviewed Jun 2, 2022
View reviewed changes
x-pack/plugins/reporting/public/lib/stream_handler.ts
@@ -22,6 +22,12 @@ import {
import { Job } from './job';
import { ReportingAPIClient } from './reporting_api_client';

/**
* @todo Replace with `Infinity` once elastic/eui#5945 is resolved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment outdated? There is no Infinity in the lower code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it isn't. I think we should replace this value with Infinity once it's supported.

tsullivan
tsullivan approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left a question about a comment that could be stale

Reviewed changes only: I did not test the code as the changes look straightforward (more so than before).

Thanks for jumping on this!!!

@dokmic dokmic merged commit 1e39a2c into elastic:main Jun 2, 2022
@dokmic dokmic deleted the bugfix/133351 branch June 2, 2022 15:02
@dokmic dokmic added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 2, 2022
kibanamachine pushed a commit that referenced this pull request Jun 2, 2022
@dokmic
[Reporting] Fix job completion notification to disappear after 24 hou…
c9f8c76 
…rs (#133381)

(cherry picked from commit 1e39a2c)
@kibanamachine kibanamachine mentioned this pull request Jun 2, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Jun 2, 2022
@dokmic
[Reporting] Fix job completion notification to disappear after 24 hou…
52dd73d 
…rs (#133381)

(cherry picked from commit 1e39a2c)
@kibanamachine kibanamachine mentioned this pull request Jun 2, 2022
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
✅ 8.2
✅ 8.3

Manual backport

To create the backport manually run:

node scripts/backport --pr 133381

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@dokmic dokmic mentioned this pull request Jun 2, 2022
Merged
kibanamachine added a commit that referenced this pull request Jun 2, 2022
@kibanamachine @dokmic
[Reporting] Fix job completion notification to disappear after 24 hou…
867fac4 
…rs (#133381) (#133408)

(cherry picked from commit 1e39a2c)

Co-authored-by: Michael Dokolin <mikhail.dokolin@elastic.co>
kibanamachine added a commit that referenced this pull request Jun 2, 2022
@kibanamachine @dokmic
[Reporting] Fix job completion notification to disappear after 24 hou…
ca9e253 
…rs (#133381) (#133407)

(cherry picked from commit 1e39a2c)

Co-authored-by: Michael Dokolin <mikhail.dokolin@elastic.co>
dokmic added a commit that referenced this pull request Jun 3, 2022
@dokmic @kibanamachine
[Reporting] Fix job completion notification to disappear after 24 hou…
4917dee 
…rs (#133381) (#133409)

(cherry picked from commit 1e39a2c)

# Conflicts:
#	x-pack/plugins/reporting/public/lib/__snapshots__/stream_handler.test.ts.snap
#	x-pack/plugins/reporting/public/lib/stream_handler.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes review v7.17.5 v8.2.3 v8.3.1 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Reporting] Job completion notification appears and disappears immediately
5 participants
@dokmic @elasticmachine @kibana-ci @kibanamachine @tsullivan