[Cases][SecOps] Fix bug where observables are not created #133752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
bug
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
academo
approved these changes
Jun 7, 2022
cnasikas
changed the title
cnasikas
changed the title
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @cnasikas |
jonathan-buttner
approved these changes
Jun 8, 2022
kibanamachine
pushed a commit
that referenced
this pull request
Jun 9, 2022
* Push observables: * Filter docs without _source (cherry picked from commit 47ffdd8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Elasticsearch client got updated to 8.0 in this PR: #113950. One of the major changes of the new version is the removal of the body
attributefrom the results of the various operations. A@ts-expect-errorin our code did not warn the author of the above PR. For that reason, if someone pushes a case to SecOps with alerts attached to the case he/she will not see any observables. The response ofmgetwhere we use to fetch the alerts) will always return an empty array because thebodyattribute is missing. This PR fixes this issue.Checklist
Delete any items that are not applicable to this PR.
For maintainers