-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] UI to edit custom pipeline|mappings #134760
Conversation
…na into feature-custom-pipeline-ui
.../agent_policy/create_package_policy_page/components/steps/components/datastream_mappings.tsx
Outdated
Show resolved
Hide resolved
export { DatastreamPipeline } from './datastream_pipelines'; | ||
export { DatastreamMappings } from './datastream_mappings'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to do anything else to export this for other plugins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be in the plugin public/index file, I exposed them in the plugin public index file
17755e7
to
555f073
Compare
67b2e1e
to
b1eca36
Compare
b1eca36
to
4f7a9cf
Compare
Pinging @elastic/fleet (Team:Fleet) |
...ns/fleet/sections/agent_policy/create_package_policy_page/components/datastream_mappings.tsx
Outdated
Show resolved
Hide resolved
const requiredVars: RegistryVarsEntry[] = []; | ||
// eslint-disable-next-line react-hooks/exhaustive-deps | ||
const advancedVars: RegistryVarsEntry[] = []; | ||
const [requiredVars, advancedVars] = useMemo(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to that PR but I add to put this in a useMemo
otherwise eslint was complaining
...s/fleet/sections/agent_policy/create_package_policy_page/components/datastream_pipelines.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code all LGTM, but I have one question below.
When I click the "edit" icon for mappings on the first integration policy created (e.g. I haven't installed Nginx yet, but I'm creating my first policy), I get an error page.
Do you think there's a way to disable the button(s) if we haven't installed the package yet? Or maybe a better solution?
...olicy/create_package_policy_page/components/steps/components/package_policy_input_stream.tsx
Outdated
Show resolved
Hide resolved
@kpollich good catch here, I am wondering if we should maybe not display that panel at all on package policy creation, in a coming PR I will add a confirm modal to block the user to navigate if it does not save the integration, and it seems the experience will be better if only show this on edition what do you think? |
This makes sense. So we'd only show these panels on edit view, not create view? |
Yes I think it will make more sense |
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @nchaulet |
Summary
Related to #133740
In 8.4.0 we plan to allow user to specify custom ingest pipeline for their Fleet managed datastream, that PR allow to show and edit these pipeline in the Fleet UI.
For this we now show two table in the advanced options section of the datastream in the package policy editor:
The link to the mappings are not redirecting bath to the editor it's waiting on that PR to land #134910
In a following PRs I will add:
Usage by custom package policy editor
We are going to expose
DatastreamPipeline
andDatastreamMappings
name and props still subject to change that could be used by integration with custom policy editor to bring back that functionality.UI Changes