Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kbnarchiver migration for x-pack/test/functional/es_archives/dashboard/drilldowns #134859

Merged
merged 8 commits into from
Jun 22, 2022
Merged

Kbnarchiver migration for x-pack/test/functional/es_archives/dashboard/drilldowns #134859

merged 8 commits into from
Jun 22, 2022

Conversation

bhavyarm
Copy link
Contributor

meta - #102552

Kbnarchiver migration PR for x-pack/test/functional/es_archives/dashboard/drilldowns

@bhavyarm bhavyarm self-assigned this Jun 21, 2022
@bhavyarm bhavyarm added test_xpack_functional Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.3.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 21, 2022
@bhavyarm bhavyarm mentioned this pull request Jun 21, 2022
Closed
@bhavyarm
Copy link
Contributor Author

Flaky test run for drilldown functional tests - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/765
Flaky test run for drilldown a11y tests - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/766

@bhavyarm bhavyarm marked this pull request as ready for review June 22, 2022 12:26
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

marius-dr
marius-dr reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@marius-dr marius-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a few questions to learn more about the process.

x-pack/test/functional/apps/discover/value_suggestions.ts Show resolved Hide resolved
x-pack/test/functional/apps/dashboard/group3/drilldowns/index.ts Show resolved Hide resolved
@marius-dr marius-dr self-requested a review June 22, 2022 13:38
marius-dr
marius-dr approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@marius-dr marius-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhavyarm bhavyarm merged commit 6c79885 into elastic:main Jun 22, 2022
kibanamachine pushed a commit that referenced this pull request Jun 22, 2022
@bhavyarm
Kbnarchiver migration for x-pack/test/functional/es_archives/dashboar…
16a0f5e 
…d/drilldowns (#134859)

(cherry picked from commit 6c79885)
@kibanamachine kibanamachine mentioned this pull request Jun 22, 2022
Closed
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 24, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134859 locally

@bhavyarm bhavyarm removed backport missing Added to PRs automatically when the are determined to be missing a backport. auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 28, 2022
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 29, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134859 locally

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134859 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134859 locally

@wayneseymour wayneseymour added the backport:skip This commit does not require backporting label Jul 4, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marius-dr marius-dr marius-dr approved these changes

@wayneseymour wayneseymour wayneseymour approved these changes

@rashmivkulkarni rashmivkulkarni Awaiting requested review from rashmivkulkarni

Assignees

@bhavyarm bhavyarm

Labels
backport:skip This commit does not require backporting Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhavyarm @kibana-ci @kibanamachine @wayneseymour @marius-dr