[Security Solution][Endpoint] Add an additional hint message for Console commands pending more than 15s #135500
Conversation
paul-tavares
added
release_note:skip
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
|
Will work on tests tomorrow |
There was a problem hiding this comment.
Works as expected. I just have a few comments.
I noticed this odd glitch that is probably unrelated to this PR. The console flickers whenever there is status output on the console. Here's screen clip in slow-mo. Probably cause it's calling and waiting on the status API to return.
...curity_solution/public/management/components/console/components/command_execution_output.tsx
Outdated
Show resolved
Hide resolved
...urity_solution/public/management/components/console/components/long_running_command_hint.tsx
Outdated
Show resolved
Hide resolved
| const elapsedSeconds = moment().diff(moment(enteredAt), 'seconds'); | ||
|
|
||
| if (elapsedSeconds >= 15) { | ||
| setIsLongRunningCommand(true); | ||
| return; | ||
| } | ||
|
|
||
| timeoutId = setTimeout(() => { | ||
| setIsLongRunningCommand(true); | ||
| }, (15 - elapsedSeconds) * 1000); | ||
| } |
There was a problem hiding this comment.
So here the elapsedSeconds never increments or is always 0. Basically, the timeout is set to execute after 15 seconds and sets the isLongRunningCommand to true. We're not actually using the time difference here.
There was a problem hiding this comment.
Not sure what you mean.
Let me explain this logic around elapsedSeconds. You can enter a command and then close the Responder window... When we re-open that same responder window, we need to determine how much time has elapsed since the command was entered so that we can correctly calculate the setTimeout() ms.
Example:
- I enter a command at
:00 sand immediately close the console - I reopen the console just 5s later.
- the
setTimeout()should now only wait10ssince 5s has already elapsed... so the(15 - elapsedSeconds)does that. - This logic here will only be triggered if
15shas not yet elapsed
There was a problem hiding this comment.
Oh, I see. When the command is executed and the console stays open beyond 15 seconds the elapsedSeconds is always 0 and thus the elapsedSeconds >= 15 block does not execute is what I meant. I didn't test it by closing and then re-opening the console, in which case the block does execute and it works as expected.
From Ash Co-authored-by: Ashokaditya <1849116+ashokaditya@users.noreply.github.com>
|
@ashokaditya thanks for pointing out that "flicker" issue. I just looked at the |
…how-hint-on-long-running-actions
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
CommandExecutionResultto use new text componentChecklist