Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Archive Migrations] x-pack-spaces-disabled_features #136302

Merged
merged 3 commits into from
Jul 18, 2022
Merged

[Archive Migrations] x-pack-spaces-disabled_features #136302

merged 3 commits into from
Jul 18, 2022

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Jul 13, 2022 •
edited
Loading

Summary

Reuse existing archive.

Helps with: #102552

@wayneseymour wayneseymour added test_xpack_functional release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.4.0 labels Jul 13, 2022
@wayneseymour wayneseymour self-assigned this Jul 13, 2022
@wayneseymour wayneseymour mentioned this pull request Jul 13, 2022
Closed
@wayneseymour wayneseymour force-pushed the migrations/spaces-disabled_features branch 2 times, most recently from 15cba96 to d12a64b Compare July 14, 2022 15:20
@wayneseymour wayneseymour marked this pull request as ready for review July 14, 2022 17:34
@wayneseymour wayneseymour force-pushed the migrations/spaces-disabled_features branch from d12a64b to ec1f9c6 Compare July 14, 2022 17:39
@wayneseymour wayneseymour requested review from LeeDr and cuff-links July 14, 2022 17:40
@wayneseymour
[Archive Migrations] x-pack-spaces-disabled_features
c57a239 
Replaces the old es archive with kbn archive.
Change test to use new archive.

Helps with: elastic#102552
@wayneseymour
Cr fixup. Use same archive, drop other.
9faa60d
@wayneseymour wayneseymour force-pushed the migrations/spaces-disabled_features branch from ec1f9c6 to 9faa60d Compare July 18, 2022 09:21
@wayneseymour wayneseymour requested a review from LeeDr July 18, 2022 15:34
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

LeeDr
LeeDr approved these changes Jul 18, 2022
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if we revise this test again we might remove one of the extra kbn_archives and just load the same one into the default and custom spaces.

@LeeDr LeeDr merged commit 7f55a1a into elastic:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeDr LeeDr LeeDr approved these changes

@cuff-links cuff-links Awaiting requested review from cuff-links

Assignees

@wayneseymour wayneseymour

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wayneseymour @kibana-ci @LeeDr