Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Add basic cypress tests for download source section #137079

Merged
merged 2 commits into from
Jul 25, 2022
Merged

[Fleet] Add basic cypress tests for download source section #137079

merged 2 commits into from
Jul 25, 2022

Conversation

criamico
Copy link
Contributor

Summary

Part of #133828

Add basic cypress tests for Fleet download source section

@criamico criamico self-assigned this Jul 25, 2022
@criamico criamico added Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0 release_note:skip Skip the PR/issue when compiling release notes and removed Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 25, 2022
@criamico criamico marked this pull request as ready for review July 25, 2022 13:34
@criamico criamico requested a review from a team as a code owner July 25, 2022 13:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

nchaulet
nchaulet approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@criamico criamico enabled auto-merge (squash) July 25, 2022 13:41
@kpollich
Copy link
Member

I've noticed the Real API should install integration without policy cypress test (pre existing to this PR) has been failing a lot lately. It seems like it just sometimes times out. Maybe we can disable it and file an issue to investigate?

@criamico
Copy link
Contributor Author

I've noticed the Real API should install integration without policy cypress test (pre existing to this PR) has been failing a lot lately. It seems like it just sometimes times out. Maybe we can disable it and file an issue to investigate?

Sure, I'll disable it in this PR then. I'll file an issue to look at it

@criamico
Copy link
Contributor Author

@kpollich I filed an issue to re-enable this spec: #137094

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #17 / machine learning - data visualizer field statistics in Discover when enabled with farequote index pattern displays the 'Field statistics' table content correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 866.2KB 866.3KB +100.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit f4348e6 into elastic:main Jul 25, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@criamico criamico

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@criamico @elasticmachine @kpollich @kibana-ci @nchaulet @kibanamachine